[dagit] Display repositories in a stable order (#7518)

dagster-io · Apr 21, 2022 · 1f1e233 · 1f1e233
1 parent 45d9c92
commit 1f1e233
Showing 1 changed file with 16 additions and 10 deletions.
diff --git a/js_modules/dagit/packages/core/src/workspace/WorkspaceContext.tsx b/js_modules/dagit/packages/core/src/workspace/WorkspaceContext.tsx
@@ -1,4 +1,5 @@
 import {ApolloQueryResult, gql, useQuery} from '@apollo/client';
+import sortBy from 'lodash/sortBy';
 import * as React from 'react';
 
 import {AppContext} from '../app/AppContext';
@@ -153,16 +154,21 @@ const useWorkspaceState = (): WorkspaceState => {
       return {allRepos, error: workspaceOrError};
     }
 
-    allRepos = workspaceOrError.locationEntries.reduce((accum, locationEntry) => {
-      if (locationEntry.locationOrLoadError?.__typename !== 'RepositoryLocation') {
-        return accum;
-      }
-      const repositoryLocation = locationEntry.locationOrLoadError;
-      const reposForLocation = repositoryLocation.repositories.map((repository) => {
-        return {repository, repositoryLocation};
-      });
-      return [...accum, ...reposForLocation];
-    }, [] as DagsterRepoOption[]);
+    allRepos = sortBy(
+      workspaceOrError.locationEntries.reduce((accum, locationEntry) => {
+        if (locationEntry.locationOrLoadError?.__typename !== 'RepositoryLocation') {
+          return accum;
+        }
+        const repositoryLocation = locationEntry.locationOrLoadError;
+        const reposForLocation = repositoryLocation.repositories.map((repository) => {
+          return {repository, repositoryLocation};
+        });
+        return [...accum, ...reposForLocation];
+      }, [] as DagsterRepoOption[]),
+
+      // Sort by repo location, then by repo
+      (r) => `${r.repositoryLocation.name}:${r.repository.name}`,
+    );
 
     return {error: null, allRepos};
   }, [workspaceOrError]);