Skip to content

Commit

Permalink
test raising exceptions in AssetGroup in deterministic order (#6945)
Browse files Browse the repository at this point in the history
  • Loading branch information
jamiedemaria committed Mar 14, 2022
1 parent 756527a commit 28d74c3
Show file tree
Hide file tree
Showing 2 changed files with 43 additions and 45 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
from dagster import asset
from dagster import AssetKey, SourceAsset, asset

patsy_cline = SourceAsset(key=AssetKey("patsy_cline"))


@asset
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -321,61 +321,57 @@ def follows_o2(o2):
def test_asset_group_from_package_name():
from . import asset_package

group = AssetGroup.from_package_name(asset_package.__name__)
assert len(group.assets) == 6
assert {asset.op.name for asset in group.assets} == {
"little_richard",
"miles_davis",
"chuck_berry",
"bb_king",
"james_brown",
"fats_domino",
}
assert {source_asset.key for source_asset in group.source_assets} == {
AssetKey("elvis_presley"),
AssetKey("buddy_holly"),
AssetKey("jerry_lee_lewis"),
}
collection_1 = AssetGroup.from_package_name(asset_package.__name__)
assert len(collection_1.assets) == 6

assets_1 = [asset.op.name for asset in collection_1.assets]
source_assets_1 = [source_asset.key for source_asset in collection_1.source_assets]

collection_2 = AssetGroup.from_package_name(asset_package.__name__)
assert len(collection_2.assets) == 6

assets_2 = [asset.op.name for asset in collection_2.assets]
source_assets_2 = [source_asset.key for source_asset in collection_2.source_assets]

assert assets_1 == assets_2
assert source_assets_1 == source_assets_2


def test_asset_group_from_package_module():
from . import asset_package

group = AssetGroup.from_package_module(asset_package)
assert len(group.assets) == 6
assert {asset.op.name for asset in group.assets} == {
"little_richard",
"miles_davis",
"chuck_berry",
"bb_king",
"james_brown",
"fats_domino",
}
assert {source_asset.key for source_asset in group.source_assets} == {
AssetKey("elvis_presley"),
AssetKey("buddy_holly"),
AssetKey("jerry_lee_lewis"),
}
collection_1 = AssetGroup.from_package_module(asset_package)
assert len(collection_1.assets) == 6

assets_1 = [asset.op.name for asset in collection_1.assets]
source_assets_1 = [source_asset.key for source_asset in collection_1.source_assets]

collection_2 = AssetGroup.from_package_module(asset_package)
assert len(collection_2.assets) == 6

assets_2 = [asset.op.name for asset in collection_2.assets]
source_assets_2 = [source_asset.key for source_asset in collection_2.source_assets]

assert assets_1 == assets_2
assert source_assets_1 == source_assets_2


def test_asset_group_from_modules():
from . import asset_package
from .asset_package import module_with_assets

group = AssetGroup.from_modules([asset_package, module_with_assets])
assert {asset.op.name for asset in group.assets} == {
"little_richard",
"chuck_berry",
"miles_davis",
"james_brown",
"fats_domino",
}
assert len(group.assets) == 5
assert {source_asset.key for source_asset in group.source_assets} == {
AssetKey("elvis_presley"),
AssetKey("buddy_holly"),
AssetKey("jerry_lee_lewis"),
}
collection_1 = AssetGroup.from_modules([asset_package, module_with_assets])

assets_1 = [asset.op.name for asset in collection_1.assets]
source_assets_1 = [source_asset.key for source_asset in collection_1.source_assets]

collection_2 = AssetGroup.from_modules([asset_package, module_with_assets])

assets_2 = [asset.op.name for asset in collection_2.assets]
source_assets_2 = [source_asset.key for source_asset in collection_2.source_assets]

assert assets_1 == assets_2
assert source_assets_1 == source_assets_2


@asset
Expand Down

0 comments on commit 28d74c3

Please sign in to comment.