[dagit] Present location reload errors after “Workspace > Reload All” (…

…#7907)
dagster-io · May 18, 2022 · 2d219f4 · 2d219f4
1 parent 445194b
commit 2d219f4
Show file tree

Hide file tree

Showing 7 changed files with 260 additions and 174 deletions.
diff --git a/js_modules/dagit/packages/core/src/nav/ReloadRepositoryLocationButton.tsx b/js_modules/dagit/packages/core/src/nav/ReloadRepositoryLocationButton.tsx
@@ -3,7 +3,7 @@ import * as React from 'react';
 import {AppContext} from '../app/AppContext';
 import {RepositoryLocationErrorDialog} from '../workspace/RepositoryLocationErrorDialog';
 
-import {useRepositoryLocationReload} from './useRepositoryLocationReload';
+import {buildReloadFnForLocation, useRepositoryLocationReload} from './useRepositoryLocationReload';
 
 type ChildProps = {
   tryReload: () => void;
@@ -21,7 +21,11 @@ export const ReloadRepositoryLocationButton: React.FC<Props> = (props) => {
 
   const {basePath} = React.useContext(AppContext);
 
-  const {reloading, error, tryReload} = useRepositoryLocationReload(location);
+  const reloadFn = React.useMemo(() => buildReloadFnForLocation(location), [location]);
+  const {reloading, error, tryReload} = useRepositoryLocationReload({
+    scope: 'location',
+    reloadFn,
+  });
 
   React.useEffect(() => setShown(!!error), [error]);
 

diff --git a/...orkspace/types/ReloadWorkspaceMutation.ts → .../src/nav/types/ReloadWorkspaceMutation.ts b/...orkspace/types/ReloadWorkspaceMutation.ts → .../src/nav/types/ReloadWorkspaceMutation.ts
diff --git a/js_modules/dagit/packages/core/src/nav/useRepositoryLocationReload.test.tsx b/js_modules/dagit/packages/core/src/nav/useRepositoryLocationReload.test.tsx
@@ -3,7 +3,7 @@ import * as React from 'react';
 
 import {TestProvider} from '../testing/TestProvider';
 
-import {useRepositoryLocationReload} from './useRepositoryLocationReload';
+import {buildReloadFnForLocation, useRepositoryLocationReload} from './useRepositoryLocationReload';
 
 describe('useRepositoryReloadLocation', () => {
   jest.useFakeTimers();
@@ -25,7 +25,11 @@ describe('useRepositoryReloadLocation', () => {
   };
 
   const Test = () => {
-    const {reloading, error, tryReload} = useRepositoryLocationReload(LOCATION);
+    const reloadFn = React.useMemo(() => buildReloadFnForLocation(LOCATION), []);
+    const {reloading, error, tryReload} = useRepositoryLocationReload({
+      scope: 'location',
+      reloadFn,
+    });
     return (
       <div>
         <div>{`Reloading: ${reloading}`}</div>