Skip to content

Commit

Permalink
[RFC] lighter weight pull request template (#7538)
Browse files Browse the repository at this point in the history
The existing template was created when we were internally using phabricator, so the target audience was only external contributors.

Now that we are using GH, I feel the template should strike a better balance between having enough information for external contributors but also being stream lined for us internally.

Personally, this was motiviated by seeing internal PRs that submit without filling out the template (or editing it away).

Very open to feedback on this, just wanted to start a discussion.
  • Loading branch information
alangenfeld committed Apr 28, 2022
1 parent 5870039 commit 3630d97
Showing 1 changed file with 2 additions and 22 deletions.
24 changes: 2 additions & 22 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,23 +1,3 @@
<!--- Hello Dagster contributor! It's great to have you with us! -->
<!-- Make sure to read https://docs.dagster.io/community/contributing -->
### Summary & Motivation

## Summary
<!-- Describe your changes here, include the motivation/context, test coverage, -->
<!-- the type of change i.e. breaking change, new feature, or bug fix -->
<!-- and related GitHub issue or screenshots (if applicable). -->




## Test Plan
<!--- Please describe the tests you have added and your testing environment (if applicable). -->




## Checklist
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask in our Slack. -->

- [ ] My change requires a change to the documentation and I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
### How I Tested These Changes

0 comments on commit 3630d97

Please sign in to comment.