Skip to content

Commit

Permalink
Fix logic to run lints on builds (#10304)
Browse files Browse the repository at this point in the history
This was backwards - we should return None (and consequently not skip)
if any Python files change.
  • Loading branch information
jmsanders committed Nov 2, 2022
1 parent 6459b0f commit 3f99335
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ def skip_reason(self) -> Optional[str]:
)
if in_scope_changes:

logging.info(f"Building {self.name} because of changes to f{in_scope_changes}")
logging.info(f"Building {self.name} because of changes to {in_scope_changes}")
return None

return "Package unaffected by these changes"
2 changes: 1 addition & 1 deletion .buildkite/dagster-buildkite/dagster_buildkite/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ def skip_if_no_python_changes():
if not is_feature_branch():
return None

if not any(path.suffix == ".py" for path in ChangedFiles.all):
if any(path.suffix == ".py" for path in ChangedFiles.all):
return None

return "No python changes"
Expand Down

0 comments on commit 3f99335

Please sign in to comment.