Unbreak windows tests (and likely the windows multiprocess executor i…

…n general) (#11679)

Summary:
SIGKILL is not a thing on windows

### Summary & Motivation

### How I Tested These Changes

python_modules/dagster/dagster/_core/test_utils.py

@@ -1,7 +1,6 @@
 import asyncio
 import os
 import re
-import signal
 import sys
 import tempfile
 import time
@@ -36,7 +35,7 @@
 from dagster._legacy import ModeDefinition, pipeline, solid
 from dagster._serdes import ConfigurableClass
 from dagster._seven.compat.pendulum import create_pendulum_time, mock_pendulum_timezone
-from dagster._utils import Counter, traced, traced_counter
+from dagster._utils import Counter, get_terminate_signal, traced, traced_counter
 from dagster._utils.error import serializable_error_info_from_exc_info
 from dagster._utils.log import configure_loggers
 from dagster._utils.merger import merge_dicts
@@ -507,12 +506,6 @@ def from_config_value(inst_data, config_value):
         return TestSecretsLoader(inst_data=inst_data, **config_value)
 
 
-def get_terminate_signal():
-    if sys.platform == "win32":
-        return signal.SIGTERM
-    return signal.SIGKILL
-
-
 def get_crash_signals():
     return [get_terminate_signal()]
 

python_modules/dagster/dagster/_utils/__init__.py

@@ -669,14 +669,20 @@ def inner(*args, **kwargs):
     return cast(T_Callable, inner)
 
 
+def get_terminate_signal():
+    if sys.platform == "win32":
+        return signal.SIGTERM
+    return signal.SIGKILL
+
+
 def get_run_crash_explanation(prefix: str, exit_code: int):
     # As per https://docs.python.org/3/library/subprocess.html#subprocess.CompletedProcess.returncode
     # negative exit code means a posix signal
     if exit_code < 0 and -exit_code in [signal.value for signal in Signals]:
         posix_signal = -exit_code
         signal_str = Signals(posix_signal).name
         exit_clause = f"was terminated by signal {posix_signal} ({signal_str})."
-        if posix_signal == Signals.SIGKILL:
+        if posix_signal == get_terminate_signal():
             exit_clause = (
                 exit_clause
                 + " This usually indicates that the process was"

python_modules/dagster/dagster_tests/general_tests/utils_tests/test_signals.py

@@ -1,6 +1,6 @@
 from signal import Signals
 
-from dagster._utils import get_run_crash_explanation
+from dagster._utils import get_run_crash_explanation, get_terminate_signal
 
 
 def test_get_run_crash_explanation():
@@ -12,5 +12,5 @@ def test_get_run_crash_explanation():
     assert (
         "foo was terminated by signal 9 (SIGKILL). This usually indicates that the process was"
         " killed by the operating system due to running out of memory."
-        in get_run_crash_explanation("foo", -Signals.SIGKILL)
+        in get_run_crash_explanation("foo", -get_terminate_signal())
     )

python_modules/dagster/dagster_tests/scheduler_tests/test_scheduler_failure_recovery.py

@@ -11,10 +11,10 @@
     cleanup_test_instance,
     create_test_daemon_workspace_context,
     get_crash_signals,
-    get_terminate_signal,
 )
 from dagster._seven import IS_WINDOWS
 from dagster._seven.compat.pendulum import create_pendulum_time, to_timezone
+from dagster._utils import get_terminate_signal
 
 from .conftest import workspace_load_target
 from .test_scheduler_run import (