Skip to content

Commit

Permalink
Increase executor event log poll interval (#7803)
Browse files Browse the repository at this point in the history
  • Loading branch information
johannkm committed May 9, 2022
1 parent 742ba2b commit 4462e81
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import os
import time
from typing import Dict, List, Optional, cast

Expand All @@ -20,6 +21,10 @@

from ..base import Executor

DEFAULT_SLEEP_SECONDS = float(
os.environ.get("DAGSTER_STEP_DELEGATING_EXECUTOR_SLEEP_SECONDS", "1.0")
)


class StepDelegatingExecutor(Executor):
def __init__(
Expand All @@ -33,7 +38,8 @@ def __init__(
self._step_handler = step_handler
self._retries = retries
self._sleep_seconds = cast(
float, check.opt_float_param(sleep_seconds, "sleep_seconds", default=0.1)
float,
check.opt_float_param(sleep_seconds, "sleep_seconds", default=DEFAULT_SLEEP_SECONDS),
)
self._check_step_health_interval_seconds = cast(
int,
Expand Down
6 changes: 4 additions & 2 deletions python_modules/libraries/dagster-k8s/dagster_k8s/executor.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,10 @@
name="k8s",
config_schema=merge_dicts(
DagsterK8sJobConfig.config_type_job(),
{"job_namespace": Field(StringSource, is_required=False)},
{"retries": get_retries_config()},
{
"job_namespace": Field(StringSource, is_required=False),
"retries": get_retries_config(),
},
),
requirements=multiple_process_executor_requirements(),
)
Expand Down

0 comments on commit 4462e81

Please sign in to comment.