add example Python incompatibilities on Py 3.6 (#8036)

dagster-io · May 25, 2022 · 49aa991 · 49aa991
1 parent 4062bca
commit 49aa991
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 13 deletions.
diff --git a/.buildkite/dagster-buildkite/dagster_buildkite/package_spec.py b/.buildkite/dagster-buildkite/dagster_buildkite/package_spec.py
@@ -106,7 +106,8 @@ class PackageSpec(
             Defaults to None.
         tox_file (str, optional): The tox file to use. Defaults to {directory}/tox.ini.
         retries (int, optional): Whether to retry these tests on failure
-        upload_coverage (bool, optional): Whether to copy coverage artifacts. Enabled by default.
+        upload_coverage (bool, optional): Whether to copy coverage artifacts. By default, enabled
+            for packages of type "core" or "library", disabled for other packages.
         timeout_in_minutes (int, optional): Fail after this many minutes.
         queue (BuildkiteQueue, optional): Schedule steps to this queue.
         run_pytest (bool, optional): Whether to run pytest. Enabled by default.
@@ -128,26 +129,27 @@ def __new__(
         env_vars: Optional[List[str]] = None,
         tox_file: Optional[str] = None,
         retries: Optional[int] = None,
-        upload_coverage: bool = True,
+        upload_coverage: Optional[bool] = None,
         timeout_in_minutes: Optional[int] = None,
         queue: Optional[BuildkiteQueue] = None,
         run_pytest: bool = True,
         run_mypy: bool = True,
         run_pylint: bool = True,
     ):
+        package_type = package_type or _infer_package_type(directory)
         return super(PackageSpec, cls).__new__(
             cls,
             directory,
             name or os.path.basename(directory),
-            package_type or _infer_package_type(directory),
+            package_type,
             unsupported_python_versions or [],
             pytest_extra_cmds,
             pytest_step_dependencies,
             pytest_tox_factors,
             env_vars or [],
             tox_file,
             retries,
-            upload_coverage,
+            upload_coverage if upload_coverage is not None else package_type in ("core", "library"),
             timeout_in_minutes,
             queue,
             run_pytest,

diff --git a/.buildkite/dagster-buildkite/dagster_buildkite/steps/packages.py b/.buildkite/dagster-buildkite/dagster_buildkite/steps/packages.py
@@ -303,36 +303,56 @@ def k8s_extra_cmds(version: str, _) -> List[str]:
     PackageSpec(
         "examples/airflow_ingest",
         unsupported_python_versions=[AvailablePythonVersion.V3_9],
-        upload_coverage=False,
+    ),
+    PackageSpec(
+        "examples/bollinger",
+        unsupported_python_versions=[
+            # dependency on dagster-pandera
+            AvailablePythonVersion.V3_6,
+        ],
     ),
     PackageSpec(
         "examples/dbt_example",
         pytest_extra_cmds=dbt_example_extra_cmds,
-        upload_coverage=False,
+        unsupported_python_versions=[
+            # dependency on dagster-dbt
+            AvailablePythonVersion.V3_6,
+        ],
     ),
     PackageSpec(
         "examples/deploy_docker",
         pytest_extra_cmds=deploy_docker_example_extra_cmds,
-        upload_coverage=False,
     ),
     PackageSpec(
         "examples/docs_snippets",
         pytest_extra_cmds=docs_snippets_extra_cmds,
-        upload_coverage=False,
         run_mypy=False,
     ),
     PackageSpec(
-        "examples/hacker_news_assets",
-        env_vars=["SNOWFLAKE_ACCOUNT", "SNOWFLAKE_USER", "SNOWFLAKE_PASSWORD"],
-        upload_coverage=False,
+        "examples/ge_example",
+        unsupported_python_versions=[
+            # dependency on dagster-ge
+            AvailablePythonVersion.V3_6,
+        ],
     ),
     PackageSpec(
         "examples/hacker_news",
         env_vars=["SNOWFLAKE_ACCOUNT", "SNOWFLAKE_USER", "SNOWFLAKE_PASSWORD"],
-        upload_coverage=False,
+        unsupported_python_versions=[
+            # dependency on dagster-dbt
+            AvailablePythonVersion.V3_6,
+        ],
+    ),
+    PackageSpec(
+        "examples/hacker_news_assets",
+        env_vars=["SNOWFLAKE_ACCOUNT", "SNOWFLAKE_USER", "SNOWFLAKE_PASSWORD"],
+        unsupported_python_versions=[
+            # dependency on dagster-dbt
+            AvailablePythonVersion.V3_6,
+        ],
     ),
-    PackageSpec("python_modules/dagit", pytest_extra_cmds=dagit_extra_cmds),
     PackageSpec("python_modules/automation"),
+    PackageSpec("python_modules/dagit", pytest_extra_cmds=dagit_extra_cmds),
     PackageSpec(
         "python_modules/dagster",
         pytest_extra_cmds=dagster_extra_cmds,