-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Community Nux] Don't use blueprint dialog (#11660)
### Summary & Motivation Get rid of some super hacky logic to "follow" the blueprint modal as it animates and just create the HTML manually myself. For a recap of why this is necessary: 1. Iframes are reloaded from scratch if their dom node gets moved 2. Blueprint doesn't insert dialog children into the DOM unless the modal is being shown 3. We want to show the modal only after the iframe is loaded (it needs to be inserted into the DOM for that to happen) So basically we want to preload the iframe that will be inside the dialog but blueprint's API doesn't technically allow that. So I made a custom dialog reusing the blueprint dialog class names so that we get the same positioning, except I insert the iframe into the DOM (rendering it offscreen) so that it can preload and then show the modal after its done loading. ### How I Tested These Changes https://www.loom.com/share/fd325fe2c0da41808cf415dea29d509a
- Loading branch information
Showing
1 changed file
with
37 additions
and
117 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters