[dagit] Replace opName with opNames everywhere (#7977)

js_modules/dagit/packages/core/src/asset-graph/AssetGraphExplorer.tsx

@@ -665,7 +665,7 @@ const opsInRange = (
     return [];
   }
   if (from.id === to.id) {
-    return [to.definition.opName!];
+    return [...to.definition.opNames];
   }
 
   if (seen.length === 0 && graphDirectionOf({graph, from, to}) === 'upstream') {
@@ -684,7 +684,7 @@ const opsInRange = (
     }
     const result: string[] = opsInRange({graph, from: node, to}, [...seen, from.id]);
     if (result.length) {
-      ledToTarget.push(from.definition.opName!, ...result);
+      ledToTarget.push(...from.definition.opNames, ...result);
     }
   }
   return uniq(ledToTarget);

js_modules/dagit/packages/core/src/asset-graph/AssetNode.tsx

@@ -31,7 +31,11 @@ export const AssetNode: React.FC<{
   padded?: boolean;
   inAssetCatalog?: boolean;
 }> = React.memo(({definition, selected, liveData, inAssetCatalog, padded = true}) => {
-  const stepKey = definition.opName || '';
+  const firstOp = definition.opNames.length ? definition.opNames[0] : null;
+
+  // Used for linking to the run with this step highlighted. We only support highlighting
+  // a single step, so just use the first one.
+  const stepKey = firstOp || '';
 
   const displayName = withMiddleTruncation(displayNameForAssetKey(definition.assetKey), {
     maxLength: ASSET_NODE_NAME_MAX_LENGTH,
@@ -64,15 +68,15 @@ export const AssetNode: React.FC<{
         {definition.description && !inAssetCatalog && (
           <Description>{markdownToPlaintext(definition.description).split('\n')[0]}</Description>
         )}
-        {definition.opName && displayName !== definition.opName && (
+        {firstOp && displayName !== firstOp && (
           <Description>
             <Box
               flex={{gap: 4, alignItems: 'flex-end'}}
               style={{marginLeft: -2, overflow: 'hidden'}}
             >
               <Icon name="op" size={16} />
               <div style={{minWidth: 0, overflow: 'hidden', textOverflow: 'ellipsis'}}>
-                {definition.opName}
+                {firstOp}
               </div>
             </Box>
           </Description>
@@ -201,7 +205,6 @@ export const AssetRunLink: React.FC<{
 export const ASSET_NODE_LIVE_FRAGMENT = gql`
   fragment AssetNodeLiveFragment on AssetNode {
     id
-    opName
     opNames
     repository {
       id
@@ -220,7 +223,6 @@ export const ASSET_NODE_FRAGMENT = gql`
   fragment AssetNodeFragment on AssetNode {
     id
     graphName
-    opName
     opNames
     description
     partitionDefinition

js_modules/dagit/packages/core/src/asset-graph/Utils.tsx

@@ -45,8 +45,8 @@ export interface GraphData {
   downstream: {[assetId: GraphId]: {[childAssetId: GraphId]: boolean}};
   upstream: {[assetId: GraphId]: {[parentAssetId: GraphId]: boolean}};
 }
-export const isSourceAsset = (node: {jobNames: string[]; opName: string | null}) => {
-  return node.jobNames.length === 0 && !node.opName;
+export const isSourceAsset = (node: {jobNames: string[]; opNames: string[]}) => {
+  return node.jobNames.length === 0 && !node.opNames.length;
 };
 
 export function identifyBundles(assetIds: string[]) {
@@ -244,8 +244,8 @@ export const buildLiveData = (
     const isPartitioned = graphNode.definition.partitionDefinition;
     const repo = repos.find((r) => r.id === liveNode.repository.id);
 
-    const runs = repo?.inProgressRunsByStep.find((r) => r.stepKey === liveNode.opName);
-    const info = repo?.latestRunByStep.find((r) => r.stepKey === liveNode.opName);
+    const runs = repo?.inProgressRunsByStep.find((r) => liveNode.opNames.includes(r.stepKey));
+    const info = repo?.latestRunByStep.find((r) => liveNode.opNames.includes(r.stepKey));
 
     const latestRunForStepKey = info?.__typename === 'LatestRun' ? info.run : null;
 

js_modules/dagit/packages/core/src/asset-graph/layout.ts

@@ -46,7 +46,7 @@ export const layoutAssetGraph = (graphData: GraphData): AssetGraphLayout => {
   });
   g.setDefaultEdgeLabel(() => ({}));
 
-  const shouldRender = (node?: GraphNode) => node && node.definition.opName;
+  const shouldRender = (node?: GraphNode) => node && node.definition.opNames.length > 0;
 
   // Add all the nodes to the graph
   Object.values(graphData.nodes)
@@ -199,15 +199,16 @@ const DISPLAY_NAME_PX_PER_CHAR = 8.0;
 
 export const getAssetNodeDimensions = (def: {
   assetKey: {path: string[]};
-  opName: string | null;
+  opNames: string[];
   description?: string | null;
 }) => {
   let height = 75;
   if (def.description) {
     height += 25;
   }
   const displayName = displayNameForAssetKey(def.assetKey);
-  if (def.opName && displayName !== def.opName) {
+  const firstOp = def.opNames[0];
+  if (firstOp && displayName !== firstOp) {
     height += 25;
   }
   return {

js_modules/dagit/packages/core/src/asset-graph/useFindJobForAsset.tsx

@@ -39,7 +39,6 @@ const ASSET_FOR_NAVIGATION_QUERY = gql`
         id
         definition {
           id
-          opName
           opNames
           jobNames
         }

js_modules/dagit/packages/core/src/assets/AssetDefinedInMultipleReposNotice.tsx

@@ -20,7 +20,7 @@ export const AssetDefinedInMultipleReposNotice: React.FC<{
       : [];
 
   const otherReposWithAsset = otherRepos.filter((r) =>
-    r.assetNodes.some((a) => a.id === assetId && a.opName),
+    r.assetNodes.some((a) => a.id === assetId && a.opNames.length),
   );
 
   if (otherReposWithAsset.length === 0) {
@@ -59,7 +59,6 @@ const ASSET_ID_SCAN_QUERY = gql`
           }
           assetNodes {
             id
-            opName
             opNames
           }
         }

js_modules/dagit/packages/core/src/assets/AssetNodeDefinition.tsx

@@ -240,7 +240,6 @@ export const ASSET_NODE_DEFINITION_FRAGMENT = gql`
     id
     description
     graphName
-    opName
     opNames
     jobNames
     repository {
@@ -259,7 +258,6 @@ export const ASSET_NODE_DEFINITION_FRAGMENT = gql`
     dependencies {
       asset {
         id
-        opName
         opNames
         jobNames
         ...AssetNodeFragment
@@ -269,7 +267,6 @@ export const ASSET_NODE_DEFINITION_FRAGMENT = gql`
     dependedBy {
       asset {
         id
-        opName
         opNames
         jobNames
         ...AssetNodeFragment

js_modules/dagit/packages/core/src/assets/AssetTable.tsx

@@ -187,7 +187,7 @@ const AssetEntryRow: React.FC<{
       <td>
         {asset ? (
           <Box flex={{gap: 8, alignItems: 'center'}}>
-            {asset.definition?.opName ? (
+            {asset.definition?.opNames.length ? (
               <Link
                 to={instanceAssetsExplorerPathToURL({
                   opsQuery: `++"${tokenForAssetKey({path})}"++`,
@@ -292,7 +292,6 @@ export const ASSET_TABLE_FRAGMENT = gql`
     }
     definition {
       id
-      opName
       opNames
       description
       repository {

js_modules/dagit/packages/core/src/assets/LaunchAssetChoosePartitionsDialog.tsx

@@ -56,7 +56,7 @@ interface Props {
   setOpen: (open: boolean) => void;
   repoAddress: RepoAddress;
   assetJobName: string;
-  assets: {assetKey: AssetKey; opName: string | null; partitionDefinition: string | null}[];
+  assets: {assetKey: AssetKey; opNames: string[]; partitionDefinition: string | null}[];
   upstreamAssetKeys: AssetKey[]; // single layer of upstream dependencies
 }
 
@@ -199,7 +199,7 @@ const LaunchAssetChoosePartitionsDialogBody: React.FC<Props> = ({
 
       const tags = [...partition.tagsOrError.results];
       const runConfigData = yaml.parse(partition.runConfigOrError.yaml || '') || {};
-      const stepKeys = assets.map((a) => a.opName!);
+      const stepKeys = assets.map((a) => a.opNames).flat();
 
       const launchResult = await client.mutate<
         LaunchPipelineExecution,
@@ -248,7 +248,7 @@ const LaunchAssetChoosePartitionsDialogBody: React.FC<Props> = ({
               },
             },
             partitionNames: selected,
-            reexecutionSteps: assets.map((a) => a.opName!),
+            reexecutionSteps: assets.map((a) => a.opNames).flat(),
             fromFailure: false,
             tags: [],
           },

js_modules/dagit/packages/core/src/assets/LaunchAssetExecutionButton.tsx

@@ -11,7 +11,6 @@ import {AssetKey} from './types';
 
 type AssetMinimal = {
   assetKey: {path: string[]};
-  opName: string | null;
   opNames: string[];
   jobNames: string[];
   partitionDefinition: string | null;

js_modules/dagit/packages/core/src/pipelines/GraphExplorer.tsx

@@ -316,7 +316,6 @@ export const GRAPH_EXPLORER_FRAGMENT = gql`
 export const GRAPH_EXPLORER_ASSET_NODE_FRAGMENT = gql`
   fragment GraphExplorerAssetNodeFragment on AssetNode {
     id
-    opName
     opNames
     assetKey {
       path

js_modules/dagit/packages/core/src/workspace/RepositoryAssetsList.tsx

@@ -26,7 +26,6 @@ const REPOSITORY_ASSETS_LIST_QUERY = gql`
           assetKey {
             path
           }
-          opName
           opNames
           description
           repository {