feat(helm): allow name override for Dagit deployment (#8005)

helm/dagster/schema/schema/charts/dagster/subschema/dagit.py

@@ -21,6 +21,7 @@ class Workspace(BaseModel):
 class Dagit(BaseModel):
     replicaCount: int
     image: kubernetes.Image
+    nameOverride: str
     service: kubernetes.Service
     workspace: Workspace
     env: Dict[str, str]

helm/dagster/schema/schema/utils/helm_template.py

@@ -24,7 +24,7 @@ class HelmTemplate:
     subchart_paths: List[str]
     output: Optional[str] = None
     model: Optional[Any] = None
-    name: str = "release-name"
+    release_name: str = "release-name"
     api_client: ApiClient = ApiClient()
 
     def render(
@@ -44,7 +44,7 @@ def render(
             command = [
                 "helm",
                 "template",
-                self.name,
+                self.release_name,
                 helm_dir_path,
                 "--debug",
                 "--values",

helm/dagster/schema/schema_tests/test_dagit.py

@@ -155,6 +155,18 @@ def test_dagit_image_tag(deployment_template: HelmTemplate):
     assert image_tag == tag
 
 
+@pytest.mark.parametrize("name_override", ["dagit", "new-name"])
+def test_dagit_name_override(deployment_template, name_override):
+    helm_values = DagsterHelmValues.construct(dagit=Dagit.construct(nameOverride=name_override))
+    dagit_deployments = deployment_template.render(helm_values)
+
+    assert len(dagit_deployments) == 1
+
+    deployment_name = dagit_deployments[0].metadata.name
+
+    assert deployment_name == f"{deployment_template.release_name}-{name_override}"
+
+
 def test_dagit_service(service_template):
     helm_values = DagsterHelmValues.construct()
     dagit_template = service_template.render(helm_values)

helm/dagster/values.yaml

@@ -38,6 +38,9 @@ dagit:
     tag: ~
     pullPolicy: Always
 
+  # Support overriding the name prefix of the Dagit pods
+  nameOverride: "dagit"
+
   service:
     type: ClusterIP
     # Defines the port where Dagit will serve requests; if changed, don't forget to update the