Restrict group names to VALID_NAME_REGEX_STR (#8214)

python_modules/dagster/dagster/core/asset_defs/decorators.py

@@ -25,7 +25,7 @@
 from dagster.core.definitions.output import Out
 from dagster.core.definitions.partition import PartitionsDefinition
 from dagster.core.definitions.resource_definition import ResourceDefinition
-from dagster.core.definitions.utils import NoValueSentinel
+from dagster.core.definitions.utils import NoValueSentinel, check_valid_name
 from dagster.core.errors import DagsterInvalidDefinitionError
 from dagster.core.storage.io_manager import IOManagerDefinition
 from dagster.core.types.dagster_type import DagsterType
@@ -215,7 +215,7 @@ def __init__(
         self.partition_mappings = partition_mappings
         self.op_tags = op_tags
         self.resource_defs = dict(check.opt_mapping_param(resource_defs, "resource_defs"))
-        self.group_name = group_name
+        self.group_name = check_valid_name(group_name) if group_name else None
 
     def __call__(self, fn: Callable) -> AssetsDefinition:
         asset_name = self.name or fn.__name__

python_modules/dagster/dagster_tests/core_tests/host_representation_tests/test_external_data.py

@@ -1,5 +1,8 @@
+import pytest
+
 from dagster import AssetKey, AssetsDefinition, GraphOut, In, Out, graph, job, op
 from dagster.core.asset_defs import AssetIn, SourceAsset, asset, build_assets_job, multi_asset
+from dagster.core.errors import DagsterInvalidDefinitionError
 from dagster.core.host_representation.external_data import (
     ExternalAssetDependedBy,
     ExternalAssetDependency,
@@ -57,6 +60,20 @@ def asset1():
     assert external_asset_nodes[0].group_name is None
 
 
+def test_asset_invalid_group_name():
+    with pytest.raises(DagsterInvalidDefinitionError):
+
+        @asset(group_name="group/with/slashes")
+        def asset2():
+            return 1
+
+    with pytest.raises(DagsterInvalidDefinitionError):
+
+        @asset(group_name="group.with.dots")
+        def asset3():
+            return 1
+
+
 def test_two_asset_job():
     @asset
     def asset1():