Skip to content

Commit

Permalink
[dagit] Repair font-sizes on Safari (#8351)
Browse files Browse the repository at this point in the history
### Summary & Motivation

I noticed a couple of font-size issues on Safari.

- The repo name in the left nav is falling back to Safari's default font-size for `button`, which means it's way too small.
- The default font size for `TextInput` is too small.

### How I Tested These Changes

Verify font-sizes on Dagit in Safari 15.5.
  • Loading branch information
hellendag committed Jun 13, 2022
1 parent 510bf07 commit 632ea3d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions js_modules/dagit/packages/core/src/ui/SectionedLeftNav.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -284,9 +284,11 @@ const SectionHeader = styled.button<{
cursor: pointer;
display: flex;
align-items: center;
font-size: 14px;
gap: 12px;
padding: 0 12px 0 24px;
text-align: left;
user-select: none;
white-space: nowrap;
height: ${({$showRepoLocation}) =>
Expand Down
1 change: 1 addition & 0 deletions js_modules/dagit/packages/ui/src/components/TextInput.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ export const TextInputStyles = css`
border-radius: 8px;
box-shadow: ${Colors.Gray300} inset 0px 0px 0px 1px, ${Colors.KeylineGray} inset 2px 2px 1.5px;
flex-grow: 1;
font-size: 14px;
line-height: 20px;
padding: 6px 6px 6px 12px;
margin: 0;
Expand Down

1 comment on commit 632ea3d

@vercel
Copy link

@vercel vercel bot commented on 632ea3d Jun 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

dagit-storybook – ./js_modules/dagit/packages/ui

dagit-storybook.vercel.app
dagit-storybook-git-master-elementl.vercel.app
dagit-storybook-elementl.vercel.app

Please sign in to comment.