Toxfile adjustments (adding mypy) (#7867)

dagster-io · May 13, 2022 · 6732a87 · 6732a87
1 parent b5d52ea
commit 6732a87
Show file tree

Hide file tree

Showing 72 changed files with 382 additions and 390 deletions.
diff --git a/examples/airflow_ingest/tox.ini b/examples/airflow_ingest/tox.ini
@@ -1,5 +1,5 @@
 [tox]
-envlist = py{39,38,37,36}-{unix,windows},pylint
+envlist = py{39,38,37,36}-{unix,windows},mypy,pylint
 skipsdist = True
 
 [testenv]
@@ -17,10 +17,10 @@ commands =
   echo -e "--- \033[0;32m:pytest: Running tox tests\033[0m"
   pytest -vv {posargs}
 
-[testenv:pylint]
+[testenv:mypy]
 commands =
-  pylint -j0 --rcfile=../../pyproject.toml {posargs} airflow_ingest
+  mypy --config=../../pyproject.toml --non-interactive --install-types {posargs} .
 
-[testenv:mypy]
+[testenv:pylint]
 commands =
-  mypy --config=../../pyproject.toml --non-interactive {posargs} .
+  pylint -j0 --rcfile=../../pyproject.toml {posargs} airflow_ingest
diff --git a/examples/basic_pyspark/tox.ini b/examples/basic_pyspark/tox.ini
@@ -1,5 +1,5 @@
 [tox]
-envlist = py{39,38,37,36}-{unix,windows},pylint
+envlist = py{39,38,37,36}-{unix,windows},mypy,pylint
 skipsdist = True
 
 [testenv]
@@ -18,10 +18,10 @@ commands =
   echo -e "--- \033[0;32m:pytest: Running tox tests\033[0m"
   pytest -vv {posargs}
 
-[testenv:pylint]
+[testenv:mypy]
 commands =
-  pylint -j0 --rcfile=../../pyproject.toml {posargs} .
+  mypy --config=../../pyproject.toml --non-interactive --install-types {posargs} .
 
-[testenv:mypy]
+[testenv:pylint]
 commands =
-  mypy --config=../../pyproject.toml --non-interactive {posargs} .
+  pylint -j0 --rcfile=../../pyproject.toml {posargs} .
diff --git a/examples/bollinger/tox.ini b/examples/bollinger/tox.ini
@@ -16,10 +16,10 @@ commands =
   !windows: /bin/bash -c '! pip list --exclude-editable | grep -e dagster -e dagit'
   pytest -vv
 
-[testenv:pylint]
+[testenv:mypy]
 commands =
-  pylint -j0 --rcfile=../../pyproject.toml {posargs} bollinger bollinger_tests
+  mypy --config=../../pyproject.toml --non-interactive --install-types {posargs} .
 
-[testenv:mypy]
+[testenv:pylint]
 commands =
-  mypy --config=../../pyproject.toml --non-interactive {posargs} .
+  pylint -j0 --rcfile=../../pyproject.toml {posargs} bollinger bollinger_tests
diff --git a/examples/dbt_example/tox.ini b/examples/dbt_example/tox.ini
@@ -1,5 +1,5 @@
 [tox]
-envlist = py{39,38,37,36}-{unix,windows},pylint
+envlist = py{39,38,37,36}-{unix,windows},mypy,pylint
 skipsdist = True
 
 [testenv]
@@ -24,10 +24,10 @@ commands =
   echo -e "--- \033[0;32m:pytest: Running tox tests\033[0m"
   pytest -vv {posargs}
 
-[testenv:pylint]
+[testenv:mypy]
 commands =
-  pylint -j0 --rcfile=../../pyproject.toml {posargs} dbt_example dbt_example_tests
+  mypy --config=../../pyproject.toml --non-interactive --install-types {posargs} .
 
-[testenv:mypy]
+[testenv:pylint]
 commands =
-  mypy --config=../../pyproject.toml --non-interactive {posargs} .
+  pylint -j0 --rcfile=../../pyproject.toml {posargs} dbt_example dbt_example_tests
diff --git a/examples/deploy_docker/tox.ini b/examples/deploy_docker/tox.ini
@@ -1,5 +1,5 @@
 [tox]
-envlist = py{39,38,37,36}-{unix,windows},pylint
+envlist = py{39,38,37,36}-{unix,windows},mypy,pylint
 skipsdist = True
 
 [testenv]
@@ -16,10 +16,10 @@ commands =
   echo -e "--- \033[0;32m:pytest: Running tox tests\033[0m"
   pytest -vv {posargs}
 
-[testenv:pylint]
+[testenv:mypy]
 commands =
-  pylint -j0 --rcfile=../../pyproject.toml {posargs} .
+  mypy --config=../../pyproject.toml --non-interactive --install-types {posargs} .
 
-[testenv:mypy]
+[testenv:pylint]
 commands =
-  mypy --config=../../pyproject.toml --non-interactive {posargs} .
+  pylint -j0 --rcfile=../../pyproject.toml {posargs} .
diff --git a/examples/deploy_ecs/tox.ini b/examples/deploy_ecs/tox.ini
@@ -1,5 +1,5 @@
 [tox]
-envlist = py{39,38,37,36}-{unix,windows},pylint
+envlist = py{39,38,37,36}-{unix,windows},mypy,pylint
 skipsdist = True
 
 [testenv]
@@ -17,10 +17,10 @@ commands =
   echo -e "--- \033[0;32m:pytest: Running tox tests\033[0m"
   pytest -s -vv {posargs}
 
-[testenv:pylint]
+[testenv:mypy]
 commands =
-  pylint -j0 --rcfile=../../pyproject.toml {posargs} .
+  mypy --config=../../pyproject.toml --non-interactive --install-types {posargs} .
 
-[testenv:mypy]
+[testenv:pylint]
 commands =
-  mypy --config=../../pyproject.toml --non-interactive {posargs} .
+  pylint -j0 --rcfile=../../pyproject.toml {posargs} .
diff --git a/examples/deploy_k8s/tox.ini b/examples/deploy_k8s/tox.ini
@@ -1,5 +1,5 @@
 [tox]
-envlist = py{39,38,37,36}-{unix,windows},pylint
+envlist = py{39,38,37,36}-{unix,windows},mypy,pylint
 skipsdist = True
 
 [testenv]
@@ -21,10 +21,10 @@ commands =
   echo -e "--- \033[0;32m:pytest: Running tox tests\033[0m"
   pytest -vv {posargs}
 
-[testenv:pylint]
+[testenv:mypy]
 commands =
-  pylint -j0 --rcfile=../../pyproject.toml {posargs} example_project tests
+  mypy --config=../../pyproject.toml --non-interactive --install-types {posargs} .
 
-[testenv:mypy]
+[testenv:pylint]
 commands =
-  mypy --config=../../pyproject.toml --non-interactive {posargs} .
+  pylint -j0 --rcfile=../../pyproject.toml {posargs} example_project tests
diff --git a/examples/docs_snippets/tox.ini b/examples/docs_snippets/tox.ini
@@ -1,5 +1,5 @@
 [tox]
-envlist = py{39,38,37,36}-{unix,windows},pylint
+envlist = py{39,38,37,36}-{unix,windows},mypy,pylint
 
 [testenv]
 usedevelop = true
@@ -30,10 +30,10 @@ commands =
   echo -e "--- \033[0;32m:pytest: Running tox tests\033[0m"
   pytest -vv {posargs}
 
-[testenv:pylint]
+[testenv:mypy]
 commands =
-  pylint -j0 --rcfile=../../pyproject.toml {posargs} docs_snippets docs_snippets_tests
+  mypy --config=../../pyproject.toml --non-interactive --install-types {posargs} .
 
-[testenv:mypy]
+[testenv:pylint]
 commands =
-  mypy --config=../../pyproject.toml --non-interactive {posargs} .
+  pylint -j0 --rcfile=../../pyproject.toml {posargs} docs_snippets docs_snippets_tests
diff --git a/examples/emr_pyspark/tox.ini b/examples/emr_pyspark/tox.ini
@@ -1,5 +1,5 @@
 [tox]
-envlist = py{39,38,37,36}-{unix,windows},pylint
+envlist = py{39,38,37,36}-{unix,windows},mypy,pylint
 skipsdist = True
 
 [testenv]
@@ -19,10 +19,10 @@ commands =
   echo -e "--- \033[0;32m:pytest: Running tox tests\033[0m"
   pytest -vv {posargs}
 
-[testenv:pylint]
+[testenv:mypy]
 commands =
-  pylint -j0 --rcfile=../../pyproject.toml {posargs} .
+  mypy --config=../../pyproject.toml --non-interactive --install-types {posargs} .
 
-[testenv:mypy]
+[testenv:pylint]
 commands =
-  mypy --config=../../pyproject.toml --non-interactive {posargs} .
+  pylint -j0 --rcfile=../../pyproject.toml {posargs} .
diff --git a/examples/ge_example/tox.ini b/examples/ge_example/tox.ini
@@ -1,5 +1,5 @@
 [tox]
-envlist = py{39,38,37,36}-{unix,windows},pylint
+envlist = py{39,38,37,36}-{unix,windows},mypy,pylint
 skipsdist = True
 
 [testenv]
@@ -21,10 +21,10 @@ commands =
   echo -e "--- \033[0;32m:pytest: Running tox tests\033[0m"
   pytest -vv {posargs}
 
-[testenv:pylint]
+[testenv:mypy]
 commands =
-  pylint -j0 --rcfile=../../pyproject.toml {posargs} ge_example ge_example_tests
+  mypy --config=../../pyproject.toml --non-interactive --install-types {posargs} .
 
-[testenv:mypy]
+[testenv:pylint]
 commands =
-  mypy --config=../../pyproject.toml --non-interactive {posargs} .
+  pylint -j0 --rcfile=../../pyproject.toml {posargs} ge_example ge_example_tests
diff --git a/examples/hacker_news/tox.ini b/examples/hacker_news/tox.ini
@@ -25,10 +25,10 @@ commands =
   echo -e "--- \033[0;32m:pytest: Running tox tests\033[0m"
   pytest -vv
 
-[testenv:pylint]
+[testenv:mypy]
 commands =
-  pylint -j0 --rcfile=../../pyproject.toml {posargs} hacker_news hacker_news_tests
+  mypy --config=../../pyproject.toml --non-interactive --install-types {posargs} .
 
-[testenv:mypy]
+[testenv:pylint]
 commands =
-  mypy --config=../../pyproject.toml --non-interactive {posargs} .
+  pylint -j0 --rcfile=../../pyproject.toml {posargs} hacker_news hacker_news_tests
diff --git a/examples/hacker_news_assets/tox.ini b/examples/hacker_news_assets/tox.ini
@@ -24,10 +24,10 @@ commands =
   echo -e "--- \033[0;32m:pytest: Running tox tests\033[0m"
   pytest -vv
 
-[testenv:pylint]
+[testenv:mypy]
 commands =
-  pylint -j0 --rcfile=../../pyproject.toml {posargs} hacker_news_assets hacker_news_assets_tests
+  mypy --config=../../pyproject.toml --non-interactive --install-types {posargs} .
 
-[testenv:mypy]
+[testenv:pylint]
 commands =
-  mypy --config=../../pyproject.toml --non-interactive {posargs} .
+  pylint -j0 --rcfile=../../pyproject.toml {posargs} hacker_news_assets hacker_news_assets_tests
diff --git a/examples/memoized_development/tox.ini b/examples/memoized_development/tox.ini
@@ -1,5 +1,5 @@
 [tox]
-envlist = py{39,38,37,36}-{unix,windows},pylint
+envlist = py{39,38,37,36}-{unix,windows},mypy,pylint
 skipsdist = True
 
 [testenv]
@@ -19,10 +19,10 @@ commands =
   echo -e "--- \033[0;32m:pytest: Running tox tests\033[0m"
   pytest -vv {posargs}
 
-[testenv:pylint]
+[testenv:mypy]
 commands =
-  pylint -j0 --rcfile=../../pyproject.toml {posargs} memoized_development tests
+  mypy --config=../../pyproject.toml --non-interactive --install-types {posargs} .
 
-[testenv:mypy]
+[testenv:pylint]
 commands =
-  mypy --config=../../pyproject.toml --non-interactive {posargs} .
+  pylint -j0 --rcfile=../../pyproject.toml {posargs} memoized_development tests
diff --git a/examples/modern_data_stack_assets/tox.ini b/examples/modern_data_stack_assets/tox.ini
@@ -21,10 +21,10 @@ commands =
   echo -e "--- \033[0;32m:pytest: Running tox tests\033[0m"
   pytest -vv
 
-[testenv:pylint]
+[testenv:mypy]
 commands =
-  pylint -j0 --rcfile=../../pyproject.toml {posargs} modern_data_stack_assets modern_data_stack_assets_tests
+  mypy --config=../../pyproject.toml --non-interactive --install-types {posargs} .
 
-[testenv:mypy]
+[testenv:pylint]
 commands =
-  mypy --config=../../pyproject.toml --non-interactive {posargs} .
+  pylint -j0 --rcfile=../../pyproject.toml {posargs} modern_data_stack_assets modern_data_stack_assets_tests
diff --git a/examples/nyt-feed/tox.ini b/examples/nyt-feed/tox.ini
@@ -1,5 +1,5 @@
 [tox]
-envlist = py{39,38,37,36}-{unix,windows},pylint
+envlist = py{39,38,37,36}-{unix,windows},mypy,pylint
 skipsdist = True
 
 [testenv]
@@ -17,10 +17,10 @@ commands =
   echo -e "--- \033[0;32m:pytest: Running tox tests\033[0m"
   pytest -vv {posargs}
 
-[testenv:pylint]
+[testenv:mypy]
 commands =
-  pylint -j0 --rcfile=../../pyproject.toml {posargs} nyt_feed nyt_feed_tests
+  mypy --config=../../pyproject.toml --non-interactive --install-types {posargs} .
 
-[testenv:mypy]
+[testenv:pylint]
 commands =
-  mypy --config=../../pyproject.toml --non-interactive {posargs} .
+  pylint -j0 --rcfile=../../pyproject.toml {posargs} nyt_feed nyt_feed_tests
diff --git a/examples/run_attribution_example/tox.ini b/examples/run_attribution_example/tox.ini
@@ -1,5 +1,5 @@
 [tox]
-envlist = py{39,38,37,36}-{unix,windows},pylint
+envlist = py{39,38,37,36}-{unix,windows},mypy,pylint
 skipsdist = True
 
 [testenv]
@@ -19,10 +19,10 @@ commands =
   echo -e "--- \033[0;32m:pytest: Running tox tests\033[0m"
   pytest -vv {posargs}
 
-[testenv:pylint]
+[testenv:mypy]
 commands =
-  pylint -j0 --rcfile=../../pyproject.toml {posargs} run_attribution_example run_attribution_example_tests
+  mypy --config=../../pyproject.toml --non-interactive --install-types {posargs} .
 
-[testenv:mypy]
+[testenv:pylint]
 commands =
-  mypy --config=../../pyproject.toml --non-interactive {posargs} .
+  pylint -j0 --rcfile=../../pyproject.toml {posargs} run_attribution_example run_attribution_example_tests
diff --git a/examples/software_defined_assets/tox.ini b/examples/software_defined_assets/tox.ini
@@ -1,5 +1,5 @@
 [tox]
-envlist = py{39,38,37,36}-{unix,windows},pylint
+envlist = py{39,38,37,36}-{unix,windows},mypy,pylint
 skipsdist = True
 
 [testenv]
@@ -19,10 +19,10 @@ commands =
   echo -e "--- \033[0;32m:pytest: Running tox tests\033[0m"
   pytest -vv {posargs}
 
-[testenv:pylint]
+[testenv:mypy]
 commands =
-  pylint -j0 --rcfile=../../pyproject.toml {posargs} software_defined_assets software_defined_assets_tests
+  mypy --config=../../pyproject.toml --non-interactive --install-types {posargs} .
 
-[testenv:mypy]
+[testenv:pylint]
 commands =
-  mypy --config=../../pyproject.toml --non-interactive {posargs} .
+  pylint -j0 --rcfile=../../pyproject.toml {posargs} software_defined_assets software_defined_assets_tests
diff --git a/examples/user_in_loop/tox.ini b/examples/user_in_loop/tox.ini
@@ -1,5 +1,5 @@
 [tox]
-envlist = py{37,36,35}-{unix,windows},pylint
+envlist = py{37,36,35}-{unix,windows},mypy,pylint
 skipsdist = True
 
 [testenv]
@@ -17,10 +17,10 @@ commands =
   echo -e "--- \033[0;32m:pytest: Running tox tests\033[0m"
   pytest -vv {posargs}
 
-[testenv:pylint]
+[testenv:mypy]
 commands =
-  pylint -j0 --rcfile=../../pyproject.toml {posargs} user_in_loop tests
+  mypy --config=../../pyproject.toml --non-interactive --install-types {posargs} .
 
-[testenv:mypy]
+[testenv:pylint]
 commands =
-  mypy --config=../../pyproject.toml --non-interactive {posargs} .
+  pylint -j0 --rcfile=../../pyproject.toml {posargs} user_in_loop tests
diff --git a/helm/dagster/schema/tox.ini b/helm/dagster/schema/tox.ini
@@ -1,5 +1,5 @@
 [tox]
-envlist = py{39,38,37,36}-{unix,windows},pylint,mypy
+envlist = py{39,38,37,36}-{unix,windows},mypy,pylint
 
 [testenv]
 setenv =
@@ -13,9 +13,10 @@ deps =
   -e ../../../python_modules/libraries/dagster-azure
   -e ../../../python_modules/libraries/dagster-gcp
   -e ../../../python_modules/libraries/dagster-k8s
-  -e .[test]
   pyparsing<3.0.0 # Hint to nudge pypi to avoid a conflict between various dagster deps
 usedevelop = true
+extras =
+  test
 allowlist_externals =
   /bin/bash
   echo
@@ -24,6 +25,10 @@ commands =
   echo -e "--- \033[0;32m:pytest: Running tox tests\033[0m"
   pytest --reruns 2 -vv {posargs}
 
+[testenv:mypy]
+commands =
+  mypy --config=../../../pyproject.toml --non-interactive --install-types {posargs} .
+
 [testenv:pylint]
 commands =
   pylint -j0 --rcfile=../../../pyproject.toml {posargs} schema_tests