Skip to content

Commit

Permalink
Restore grpcio pin for python 3.10 (#11784)
Browse files Browse the repository at this point in the history
Summary:
Hangs in python 3.10 in grpc seem to be happening after all - it's
possible they are a bit more rare, but they definitely happen:
https://buildkite.com/dagster/dagster/builds/46036#0185c6be-2c65-4ea7-b368-3c80a933f7bc

so for now we need to bring back the pin for all versions I think.

### Summary & Motivation

### How I Tested These Changes
  • Loading branch information
gibsondan authored and alangenfeld committed Jan 19, 2023
1 parent b7ad6f5 commit 6c41bf4
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions python_modules/dagster/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,9 @@ def get_version() -> str:
# pin around issues in specific versions of alembic that broke our migrations
"alembic>=1.2.1,!=1.6.3,!=1.7.0",
"croniter>=0.3.34",
# grpcio>=1.48.1 has hanging/crashing issues for python 3.9 and earlier: https://github.com/grpc/grpc/issues/30843
# grpcio>=1.48.1 has hanging/crashing issues: https://github.com/grpc/grpc/issues/30843 and https://github.com/grpc/grpc/issues/31885
# ensure version we require is >= that with which we generated the grpc code (set in dev-requirements)
"grpcio>=1.32.0,<1.48.1; python_version < '3.10'",
"grpcio>=1.32.0; python_version >= '3.10'",
"grpcio>=1.32.0,<1.48.1",
"grpcio-health-checking>=1.32.0,<1.44.0",
"packaging>=20.9",
"pendulum",
Expand Down

0 comments on commit 6c41bf4

Please sign in to comment.