feat: add alert failure event (#7238)

dagster-io · Mar 30, 2022 · 7024d7c · 7024d7c
1 parent 847889d
commit 7024d7c
Show file tree

Hide file tree

Showing 14 changed files with 38 additions and 9 deletions.
diff --git a/js_modules/dagit/packages/core/src/graphql/possibleTypes.generated.json b/js_modules/dagit/packages/core/src/graphql/possibleTypes.generated.json
diff --git a/js_modules/dagit/packages/core/src/graphql/schema.graphql b/js_modules/dagit/packages/core/src/graphql/schema.graphql
diff --git a/js_modules/dagit/packages/core/src/runs/LogsRowStructuredContent.tsx b/js_modules/dagit/packages/core/src/runs/LogsRowStructuredContent.tsx
@@ -166,7 +166,9 @@ export const LogsRowStructuredContent: React.FC<IStructuredContentProps> = ({nod
     case 'AlertStartEvent':
       return <DefaultContent eventType={eventType} message={node.message} />;
     case 'AlertSuccessEvent':
-      return <DefaultContent eventType={eventType} message={node.message} />;
+      return <DefaultContent eventType={eventType} message={node.message} eventIntent="success" />;
+    case 'AlertFailureEvent':
+      return <DefaultContent eventType={eventType} message={node.message} eventIntent="warning" />;
     case 'RunFailureEvent':
       if (node.pipelineFailureError) {
         return (

diff --git a/js_modules/dagit/packages/core/src/runs/types/LogsRowStructuredFragment.ts b/js_modules/dagit/packages/core/src/runs/types/LogsRowStructuredFragment.ts
diff --git a/js_modules/dagit/packages/core/src/runs/types/LogsRowUnstructuredFragment.ts b/js_modules/dagit/packages/core/src/runs/types/LogsRowUnstructuredFragment.ts
diff --git a/js_modules/dagit/packages/core/src/runs/types/LogsScrollingTableMessageFragment.ts b/js_modules/dagit/packages/core/src/runs/types/LogsScrollingTableMessageFragment.ts
diff --git a/js_modules/dagit/packages/core/src/runs/types/PipelineRunLogsSubscription.ts b/js_modules/dagit/packages/core/src/runs/types/PipelineRunLogsSubscription.ts
diff --git a/js_modules/dagit/packages/core/src/runs/types/RunDagsterRunEventFragment.ts b/js_modules/dagit/packages/core/src/runs/types/RunDagsterRunEventFragment.ts
diff --git a/js_modules/dagit/packages/core/src/runs/types/RunLogsQuery.ts b/js_modules/dagit/packages/core/src/runs/types/RunLogsQuery.ts
diff --git a/js_modules/dagit/packages/core/src/runs/types/RunMetadataProviderMessageFragment.ts b/js_modules/dagit/packages/core/src/runs/types/RunMetadataProviderMessageFragment.ts
diff --git a/js_modules/dagit/packages/core/src/types/globalTypes.ts b/js_modules/dagit/packages/core/src/types/globalTypes.ts
diff --git a/python_modules/dagster-graphql/dagster_graphql/implementation/events.py b/python_modules/dagster-graphql/dagster_graphql/implementation/events.py
@@ -153,6 +153,7 @@ def _to_metadata_entries(metadata_entries):
 def from_dagster_event_record(event_record, pipeline_name):
     from ..schema.errors import GraphenePythonError
     from ..schema.logs.events import (
+        GrapheneAlertFailureEvent,
         GrapheneAlertStartEvent,
         GrapheneAlertSuccessEvent,
         GrapheneEngineEvent,
@@ -292,6 +293,8 @@ def from_dagster_event_record(event_record, pipeline_name):
         return GrapheneAlertStartEvent(pipelineName=pipeline_name, **basic_params)
     elif dagster_event.event_type == DagsterEventType.ALERT_SUCCESS:
         return GrapheneAlertSuccessEvent(pipelineName=pipeline_name, **basic_params)
+    elif dagster_event.event_type == DagsterEventType.ALERT_FAILURE:
+        return GrapheneAlertFailureEvent(pipelineName=pipeline_name, **basic_params)
     elif dagster_event.event_type == DagsterEventType.HANDLED_OUTPUT:
         return GrapheneHandledOutputEvent(
             output_name=dagster_event.event_specific_data.output_name,

diff --git a/python_modules/dagster-graphql/dagster_graphql/schema/logs/events.py b/python_modules/dagster-graphql/dagster_graphql/schema/logs/events.py
@@ -120,6 +120,12 @@ class Meta:
         name = "AlertSuccessEvent"
 
 
+class GrapheneAlertFailureEvent(graphene.ObjectType):
+    class Meta:
+        interfaces = (GrapheneMessageEvent, GrapheneRunEvent)
+        name = "AlertFailureEvent"
+
+
 class GrapheneStepEvent(graphene.Interface):
     stepKey = graphene.Field(graphene.String)
     solidHandleID = graphene.Field(graphene.String)
@@ -457,6 +463,7 @@ class Meta:
             GrapheneHookErroredEvent,
             GrapheneAlertStartEvent,
             GrapheneAlertSuccessEvent,
+            GrapheneAlertFailureEvent,
         )
         name = "DagsterRunEvent"
 

diff --git a/python_modules/dagster/dagster/core/events/__init__.py b/python_modules/dagster/dagster/core/events/__init__.py
@@ -115,6 +115,8 @@ class DagsterEventType(Enum):
 
     ALERT_START = "ALERT_START"
     ALERT_SUCCESS = "ALERT_SUCCESS"
+    ALERT_FAILURE = "ALERT_FAILURE"
+
     LOGS_CAPTURED = "LOGS_CAPTURED"
 
 
@@ -172,6 +174,7 @@ class DagsterEventType(Enum):
 ALERT_EVENTS = {
     DagsterEventType.ALERT_START,
     DagsterEventType.ALERT_SUCCESS,
+    DagsterEventType.ALERT_FAILURE,
 }