Skip to content

Commit

Permalink
one more windows test fix for signals (#11680)
Browse files Browse the repository at this point in the history
Summary:
Underlying functionality is now working, but a test failure remains -
will actually let the windows build finish this time

Test Plan: Azure and BK

### Summary & Motivation

### How I Tested These Changes
  • Loading branch information
gibsondan committed Jan 13, 2023
1 parent 08dec7d commit 71e060a
Showing 1 changed file with 8 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,15 @@
def test_get_run_crash_explanation():
assert get_run_crash_explanation("foo", 1) == "foo unexpectedly exited with code 1."
assert (
get_run_crash_explanation("foo", -Signals.SIGTERM)
== "foo was terminated by signal 15 (SIGTERM)."
get_run_crash_explanation("foo", -Signals.SIGINT)
== "foo was terminated by signal 2 (SIGINT)."
)

term_signal = get_terminate_signal()

assert (
"foo was terminated by signal 9 (SIGKILL). This usually indicates that the process was"
" killed by the operating system due to running out of memory."
f"foo was terminated by signal {term_signal} ({term_signal.name}). This usually"
" indicates that the process was killed by the operating system due to running out of"
" memory."
in get_run_crash_explanation("foo", -get_terminate_signal())
)

0 comments on commit 71e060a

Please sign in to comment.