Skip to content

Commit

Permalink
add ipython_genutils as dagit, dagstermill dep (#7016)
Browse files Browse the repository at this point in the history
  • Loading branch information
smackesey committed Mar 11, 2022
1 parent b86b0f1 commit 7542130
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 1 deletion.
1 change: 1 addition & 0 deletions docs/docs-build-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,4 @@ google-api-python-client<2.0.0
google-cloud-storage
paramiko
papermill>=1.0.0
ipython_genutils>=0.2.0
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# pins for recently released packages that cause problems in older dagster versions
markupsafe<=2.0.1
grpcio-health-checking<1.44.0

# We implicitly depended on this in older versions.
ipython_genutils>=0.2.0
6 changes: 6 additions & 0 deletions python_modules/dagit/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,12 @@ def get_version():
"click>=7.0,<9.0",
f"dagster{pin}",
f"dagster-graphql{pin}",
# See: https://github.com/mu-editor/mu/pull/1844
# ipykernel<6 depends on ipython_genutils, but it isn't explicitly
# declared as a dependency. It also depends on traitlets, which
# incidentally brought ipython_genutils, but in v5.1 it was dropped, so as
# a workaround we need to manually specify it here
"ipython_genutils>=0.2.0",
"requests",
# watchdog
"watchdog>=0.8.3",
Expand Down
8 changes: 7 additions & 1 deletion python_modules/libraries/dagstermill/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,15 @@ def get_version() -> str:
# https://github.com/nteract/papermill/issues/519,
# https://github.com/ipython/ipykernel/issues/568
"ipykernel>=4.9.0,!=5.4.0,!=5.4.1",
"scrapbook>=0.5.0",
# See: https://github.com/mu-editor/mu/pull/1844
# ipykernel<6 depends on ipython_genutils, but it isn't explicitly
# declared as a dependency. It also depends on traitlets, which
# incidentally brought ipython_genutils, but in v5.1 it was dropped, so as
# a workaround we need to manually specify it here
"ipython_genutils>=0.2.0",
"packaging>=20.5",
"papermill>=1.0.0",
"scrapbook>=0.5.0",
],
extras_require={
"test": [
Expand Down

1 comment on commit 7542130

@vercel
Copy link

@vercel vercel bot commented on 7542130 Mar 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.