Skip to content

Commit

Permalink
enable loaded_input metadata entries to display in Dagit (#7255)
Browse files Browse the repository at this point in the history
  • Loading branch information
clairelin135 committed Apr 4, 2022
1 parent da2205e commit 79235ab
Show file tree
Hide file tree
Showing 11 changed files with 777 additions and 4 deletions.

Large diffs are not rendered by default.

5 changes: 4 additions & 1 deletion js_modules/dagit/packages/core/src/graphql/schema.graphql

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions js_modules/dagit/packages/core/src/runs/LogsRow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,9 @@ export const LOGS_ROW_STRUCTURED_FRAGMENT = gql`
managerKey
upstreamOutputName
upstreamStepKey
metadataEntries {
...MetadataEntryFragment
}
}
... on EngineEvent {
metadataEntries {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,11 @@ export const LogsRowStructuredContent: React.FC<IStructuredContentProps> = ({nod
</DefaultContent>
);
case 'LoadedInputEvent':
return <DefaultContent message={node.message} eventType={eventType} />;
return (
<DefaultContent message={node.message} eventType={eventType}>
<MetadataEntries entries={node.metadataEntries} />
</DefaultContent>
);
case 'HookCompletedEvent':
return <DefaultContent eventType={eventType} message={node.message} />;
case 'HookSkippedEvent':
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 79235ab

Please sign in to comment.