Skip to content

Commit

Permalink
[refactor] Delete NodeInput.solid_name (#12339)
Browse files Browse the repository at this point in the history
### Summary & Motivation

- Delete `NodeInput.solid_name`, update references to existing
`NodeInput.node_name`

### How I Tested These Changes

BK
  • Loading branch information
smackesey committed Feb 15, 2023
1 parent e81c9b1 commit 915feb5
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def _resolve_output_to_destinations(
for input_handle in downstream_input_handles:
all_destinations.append(
NodeInputHandle(
NodeHandle(input_handle.solid_name, parent=handle), input_handle.input_name
NodeHandle(input_handle.node_name, parent=handle), input_handle.input_name
)
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -570,10 +570,6 @@ def __eq__(self, other: object) -> bool:
def node_name(self) -> str:
return self.node.name

@property
def solid_name(self) -> str:
return self.node.name

@property
def input_name(self) -> str:
return self.input_def.name
Expand All @@ -600,10 +596,10 @@ def __str__(self):
def __repr__(self):
return self._inner_str()

def __hash__(self):
def __hash__(self) -> int:
return hash((self.node.name, self.output_def.name))

def __eq__(self, other: Any):
def __eq__(self, other: Any) -> bool:
return self.node.name == other.node.name and self.output_def.name == other.output_def.name

def describe(self) -> str:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ def generate_dep_graph(pipeline_def: "PipelineDefinition") -> DependencyGraph[st
downstream_dep = dependency_structure.output_to_downstream_inputs_for_node(item_name)
for downstreams in downstream_dep.values():
for down in downstreams:
graph["downstream"][item_name].add(down.solid_name)
graph["downstream"][item_name].add(down.node_name)

return graph

Expand Down

0 comments on commit 915feb5

Please sign in to comment.