Skip to content

Commit

Permalink
[dagit] Show default value for config (#7598)
Browse files Browse the repository at this point in the history
## Summary

Expose `defaultValueAsJson` as a field on `CompositeConfigType`, and use it to display config defaults in the launchpad schema pane.

For fields in the schema that do have defaults, render a subtle underline. Hover on the field, and a tooltip appears with the default config value.

I don't know if there's a good way to expose defaults without hiding them behind some interaction, because the space here is so limited.

Open to others' thoughts on this.

## Test Plan

View Launchpad, hover over keys in the schema pane. Verify that the tooltip appears, with nicely formatted JSON.
  • Loading branch information
hellendag committed Apr 28, 2022
1 parent b9be0d4 commit 9345ebc
Show file tree
Hide file tree
Showing 30 changed files with 460 additions and 40 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 9345ebc

Please sign in to comment.