-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[dagit] Fix CodeMirror show-hint error (#7334)
## Summary There is an error within the CodeMirror show-hint addon that fires on an empty Launchpad. This appears to be because we aren't providing `from` and `to` values in the return value for the `hint` helper function, and they are expected to be there. Add them. ## Test Plan View Launchpad, clear out editor config. Start typing in the empty editor, verify that hint suggestions render properly and that there are no JS errors in the console.
- Loading branch information
Showing
1 changed file
with
20 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters