Skip to content

Commit

Permalink
remove usable_as_dagster_type from integrations (#7682)
Browse files Browse the repository at this point in the history
  • Loading branch information
sryza committed May 5, 2022
1 parent 2930507 commit a4ffde0
Show file tree
Hide file tree
Showing 10 changed files with 5 additions and 25 deletions.
3 changes: 0 additions & 3 deletions python_modules/dagster/dagster/core/storage/file_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,12 @@
from dagster.config.source import StringSource
from dagster.core.definitions.resource_definition import resource
from dagster.core.instance import DagsterInstance
from dagster.core.types.decorator import usable_as_dagster_type
from dagster.utils import mkdir_p

from .temp_file_manager import TempfileManager


# pylint: disable=no-init
@usable_as_dagster_type
class FileHandle(ABC):
"""A reference to a file as manipulated by a FileManager
Expand All @@ -38,7 +36,6 @@ def path_desc(self) -> str:
raise NotImplementedError()


@usable_as_dagster_type
class LocalFileHandle(FileHandle):
"""A reference to a file on a local filesystem."""

Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
from typing import Any, Dict, NamedTuple

from dagster import usable_as_dagster_type


@usable_as_dagster_type
class AirbyteOutput(
NamedTuple(
"_AirbyteOutput",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import uuid
from contextlib import contextmanager

from dagster import check, usable_as_dagster_type
from dagster import check
from dagster.core.storage.file_manager import (
FileHandle,
FileManager,
Expand All @@ -11,7 +11,6 @@
)


@usable_as_dagster_type
class S3FileHandle(FileHandle):
"""A reference to a file on S3."""

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import uuid
from contextlib import contextmanager

from dagster import check, usable_as_dagster_type
from dagster import check
from dagster.core.storage.file_manager import (
FileHandle,
FileManager,
Expand All @@ -11,7 +11,6 @@
)


@usable_as_dagster_type
class ADLS2FileHandle(FileHandle):
"""A reference to a file on ADLS2."""

Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
from typing import Any, Dict, NamedTuple

from dagster import usable_as_dagster_type


@usable_as_dagster_type
class CensusOutput(
NamedTuple(
"_CensusOutput",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
from typing import Any, Dict, List

from dagster import check, usable_as_dagster_type
from dagster import check

from ..types import DbtOutput


@usable_as_dagster_type
class DbtCliOutput(DbtOutput):
"""The results of executing a dbt command, along with additional metadata about the dbt CLI
process that was run.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,11 @@

from dateutil.parser import isoparse

from dagster import check, usable_as_dagster_type
from dagster import check

from ..types import DbtOutput


@usable_as_dagster_type
class DbtCloudOutput(DbtOutput):
"""The results of executing a dbt Cloud job, along with additional metadata produced from the
job run.
Expand Down
3 changes: 0 additions & 3 deletions python_modules/libraries/dagster-dbt/dagster_dbt/rpc/types.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,9 @@

import requests

from dagster import usable_as_dagster_type

from ..types import DbtOutput


@usable_as_dagster_type
class DbtRpcOutput(DbtOutput):
"""The output from executing a dbt command via the dbt RPC server.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
from typing import Any, Dict, NamedTuple

from dagster import usable_as_dagster_type


@usable_as_dagster_type
class FivetranOutput(
NamedTuple(
"_FivetranOutput",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

from google.cloud import storage # type: ignore

from dagster import check, usable_as_dagster_type
from dagster import check
from dagster.core.storage.file_manager import (
FileHandle,
FileManager,
Expand All @@ -13,7 +13,6 @@
)


@usable_as_dagster_type
class GCSFileHandle(FileHandle):
"""A reference to a file on GCS."""

Expand Down

0 comments on commit a4ffde0

Please sign in to comment.