use DisplayableEvent in dagit log viewer (#8323)

Summary: There are a bunch of duplicate fields in the logger query that exist on a shared interface - use that interface instead. Test Plan: View structured log viewer on a run before and after this PR, no changes
dagster-io · Jun 10, 2022 · ab62a16 · ab62a16
1 parent 3a1d95b
commit ab62a16
Show file tree

Hide file tree

Showing 11 changed files with 2,739 additions and 2,714 deletions.
diff --git a/js_modules/dagit/packages/core/src/assets/types/AssetEventsQuery.ts b/js_modules/dagit/packages/core/src/assets/types/AssetEventsQuery.ts
diff --git a/js_modules/dagit/packages/core/src/assets/types/AssetMaterializationFragment.ts b/js_modules/dagit/packages/core/src/assets/types/AssetMaterializationFragment.ts
diff --git a/js_modules/dagit/packages/core/src/assets/types/AssetObservationFragment.ts b/js_modules/dagit/packages/core/src/assets/types/AssetObservationFragment.ts
diff --git a/js_modules/dagit/packages/core/src/graphql/schema.graphql b/js_modules/dagit/packages/core/src/graphql/schema.graphql
diff --git a/js_modules/dagit/packages/core/src/runs/LogsRow.tsx b/js_modules/dagit/packages/core/src/runs/LogsRow.tsx
@@ -104,24 +104,21 @@ export const LOGS_ROW_STRUCTURED_FRAGMENT = gql`
       level
       stepKey
     }
-    ... on MaterializationEvent {
-      assetKey {
-        path
-      }
+    ... on DisplayableEvent {
       label
       description
       metadataEntries {
         ...MetadataEntryFragment
       }
     }
-    ... on ObservationEvent {
+    ... on MaterializationEvent {
       assetKey {
         path
       }
-      label
-      description
-      metadataEntries {
-        ...MetadataEntryFragment
+    }
+    ... on ObservationEvent {
+      assetKey {
+        path
       }
     }
     ... on RunFailureEvent {
@@ -166,9 +163,6 @@ export const LOGS_ROW_STRUCTURED_FRAGMENT = gql`
           ...MetadataEntryFragment
         }
       }
-      metadataEntries {
-        ...MetadataEntryFragment
-      }
     }
     ... on StepExpectationResultEvent {
       expectationResult {
@@ -191,23 +185,14 @@ export const LOGS_ROW_STRUCTURED_FRAGMENT = gql`
     ... on HandledOutputEvent {
       outputName
       managerKey
-      metadataEntries {
-        ...MetadataEntryFragment
-      }
     }
     ... on LoadedInputEvent {
       inputName
       managerKey
       upstreamOutputName
       upstreamStepKey
-      metadataEntries {
-        ...MetadataEntryFragment
-      }
     }
     ... on EngineEvent {
-      metadataEntries {
-        ...MetadataEntryFragment
-      }
       engineError: error {
         ...PythonErrorFragment
       }