Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: TIL that pop_stack doesn't actually close the contextmanagers in the stack! https://docs.python.org/3/library/contextlib.html#contextlib.ExitStack.pop_all I think what we actually want is close(). Resolves #3757. Test Plan: Run daemon loop long enough that the pop_all is hit (>60 seconds), CTRL-C the daemon, daemon no longer hangs. Reviewers: prha, johann, alangenfeld Reviewed By: johann Differential Revision: https://dagster.phacility.com/D6757
- Loading branch information