Skip to content

Commit

Permalink
[airbyte] Consider keys containing credentials a secret (#11620)
Browse files Browse the repository at this point in the history
### Summary & Motivation

There are lots of keys which should be secret, such as any of google
api's `credentials_json` fields that are currently not masked. The
Airbyte api also does not return these fields, so they are always
considered a diff, even if the credential is correctly applied

### How I Tested These Changes

I made the requested change locally, and then tested the CLI `apply` and
`check` commands. Fields with `credentials_json` were correctly masked
and applied
  • Loading branch information
joel-olazagasti committed Jan 18, 2023
1 parent 7e582d7 commit bd7cb10
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class ManagedElementError(enum.Enum):
CANNOT_CONNECT = "cannot_connect"


SANITIZE_KEY_KEYWORDS = ["password", "token", "secret", "ssh_key"]
SANITIZE_KEY_KEYWORDS = ["password", "token", "secret", "ssh_key", "credentials"]
SANITIZE_KEY_EXACT_MATCHES = ["pat"]

SECRET_MASK_VALUE = "**********"
Expand Down

0 comments on commit bd7cb10

Please sign in to comment.