test(graphql): ensure type names do not leak graphene (#8345)

js_modules/dagit/packages/core/src/app/Permissions.tsx

@@ -83,7 +83,7 @@ const PERMISSIONS_QUERY = gql`
     }
   }
 
-  fragment PermissionFragment on GraphenePermission {
+  fragment PermissionFragment on Permission {
     permission
     value
   }

js_modules/dagit/packages/core/src/testing/TestProvider.tsx

@@ -53,7 +53,7 @@ export const TestProvider: React.FC<Props> = (props) => {
     return Object.keys(PERMISSIONS_ALLOW_ALL).map((permission) => {
       const override = permissionOverrides ? permissionOverrides[permission] : null;
       const value = typeof override === 'boolean' ? override : true;
-      return {__typename: 'GraphenePermission', permission, value};
+      return {__typename: 'Permission', permission, value};
     });
   }, [permissionOverrides]);
 

python_modules/dagster-graphql/dagster_graphql/schema/permissions.py

@@ -6,7 +6,7 @@
 
 class GraphenePermission(graphene.ObjectType):
     class Meta:
-        "Permission"
+        name = "Permission"
 
     permission = graphene.NonNull(graphene.String)
     value = graphene.NonNull(graphene.Boolean)

python_modules/dagster-graphql/dagster_graphql_tests/test_schema.py

@@ -1,11 +1,37 @@
-from dagster_graphql.schema import types
+import json
 
+import pytest
+from click.testing import CliRunner
+from dagster_graphql.cli import ui
 
-def test_schema_naming_invariant():
-    violations = []
-    for type_ in types():
-        if type_.__name__ != f"Graphene{type_._meta.name}":  # pylint: disable=protected-access
-            violations.append(
-                (type_.__name__, f"Graphene{type_._meta.name}")  # pylint: disable=protected-access
-            )
-    assert not violations, violations
+
+@pytest.fixture(name="runner")
+def runner_fixture():
+    yield CliRunner()
+
+
+def test_schema_type_names_without_graphene(runner):
+    query = """
+    query GetSchemaTypeNames {
+        __schema {
+            types {
+                name
+            }
+        }
+    }
+    """
+
+    result = runner.invoke(
+        ui,
+        ["--empty-workspace", "--ephemeral-instance", "-t", query],
+    )
+    graphql_schema_types = json.loads(result.output)["data"]["__schema"]["types"]
+
+    violations = [
+        graphql_type["name"]
+        for graphql_type in graphql_schema_types
+        if "Graphene".casefold() in graphql_type["name"].casefold()
+    ]
+    assert (
+        not violations
+    ), f"'Graphene' cannot be included in the GraphQL type name. Violating types: {violations}."