Skip to content

Commit

Permalink
disable check_same_thread on in-memory sqlite storage (#12229)
Browse files Browse the repository at this point in the history
I tried using `dagit-debug` for the first time in a while and ran in to
this check causing all web requests to fail. I think its safe enough to
disable this.

### How I Tested These Changes

run `dagit-debug <debug file`>` and look at a run
  • Loading branch information
alangenfeld committed Feb 15, 2023
1 parent 94d89b2 commit c488fdb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion python_modules/dagster/dagster/_core/storage/sqlite.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def create_in_memory_conn_string(db_name: str) -> str:
# that multiple instances can share the same logical DB across connections, while maintaining
# separate DBs for different db names. The latter is required to have both the run / event_log
# in-memory implementations within the same process
return f"sqlite:///file:{db_name}?mode=memory&uri=true"
return f"sqlite:///file:{db_name}?mode=memory&uri=true&check_same_thread=false"


def get_sqlite_version() -> str:
Expand Down

0 comments on commit c488fdb

Please sign in to comment.