Skip to content

Commit

Permalink
Fixup ECS docs (#7193)
Browse files Browse the repository at this point in the history
Without the quotes, the YAML fails to parse with:

```
yaml.scanner.ScannerError: mapping values are not allowed here
```

Also, there were a few dangling closing brackets/braces left-over
presumably from copy-pasting this as JSON and reformatting it to YAML.
  • Loading branch information
jmsanders committed Mar 28, 2022
1 parent 8378c0c commit d0188e4
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions docs/content/deployment/guides/aws.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -129,11 +129,9 @@ run_launcher:
config:
secrets:
- name: "MY_API_TOKEN"
valueFrom: arn:aws:secretsmanager:us-east-1:123456789012:secret:FOO-AbCdEf:token::
valueFrom: "arn:aws:secretsmanager:us-east-1:123456789012:secret:FOO-AbCdEf:token::"
- name: "MY_PASSWORD"
valueFrom: arn:aws:secretsmanager:us-east-1:123456789012:secret:FOO-AbCdEf:password::
]
}
valueFrom: "arn:aws:secretsmanager:us-east-1:123456789012:secret:FOO-AbCdEf:password::"
```

Any secret tagged with `dagster` will be included in the environment. `MY_API_TOKEN` and `MY_PASSWORD` will also be included in the environment.
Expand Down

1 comment on commit d0188e4

@vercel
Copy link

@vercel vercel bot commented on d0188e4 Mar 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.