Skip to content

Commit

Permalink
fix volumes example for docker run launcher (#7607)
Browse files Browse the repository at this point in the history
Summary:
This doc incorrectly implies that docker volumes can be relative paths - they need to be absolute (dagster.yaml is loaded inside the Docker container and doesn't know the working directory outside of the callsite outside of the container)

Test Plan: View docs
  • Loading branch information
gibsondan committed Apr 27, 2022
1 parent 7ed2dbd commit d0d4d5d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion docs/content/deployment/guides/docker.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ run_launcher:
- DAGSTER_POSTGRES_DB
container_kwargs:
volumes:
- repo.py:/opt/dagster/app/
- /absolute/path/to/local/repo.py:/opt/dagster/app/
```

## Example
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ run_launcher:
- DAGSTER_POSTGRES_DB
container_kwargs:
volumes:
- repo.py:/opt/dagster/app/
- /absolute/path/to/local/repo.py:/opt/dagster/app/

1 comment on commit d0d4d5d

@vercel
Copy link

@vercel vercel bot commented on d0d4d5d Apr 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.