Skip to content

Commit

Permalink
Switch new partition page to use more efficient partition status query (
Browse files Browse the repository at this point in the history
#7663)

* core partition status storage query

* fix

* status

* fix tests

* rebase
  • Loading branch information
prha committed May 3, 2022
1 parent d4293b8 commit d32fcff
Show file tree
Hide file tree
Showing 8 changed files with 243 additions and 65 deletions.
1 change: 1 addition & 0 deletions js_modules/dagit/packages/core/src/graphql/schema.graphql

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ import {
} from '../instance/types/LaunchPartitionBackfill';
import {LaunchButton} from '../launchpad/LaunchButton';
import {TagContainer, TagEditor} from '../launchpad/TagEditor';
import {explodeCompositesInHandleGraph} from '../pipelines/CompositeSupport';
import {GRAPH_EXPLORER_SOLID_HANDLE_FRAGMENT} from '../pipelines/GraphExplorer';
import {RunStatus} from '../types/globalTypes';
import {GraphQueryInput} from '../ui/GraphQueryInput';
import {repoAddressToSelector} from '../workspace/repoAddressToSelector';
Expand Down Expand Up @@ -128,7 +130,9 @@ export const BackfillPartitionSelector: React.FC<{
}

const {pipelineSnapshotOrError: pipelineSnapshot, instance} = data;
const solids = pipelineSnapshot.solidHandles.map((h: any) => h.solid);
const solids = explodeCompositesInHandleGraph(pipelineSnapshot.solidHandles).map(
(h: any) => h.solid,
);
const solidsFiltered = filterByQuery(solids, query);
const layout = buildLayout({nodes: solidsFiltered.all, mode: GanttChartMode.FLAT});
const stepRows = layout.boxes.map((box) => ({
Expand Down Expand Up @@ -456,6 +460,7 @@ const BACKFILL_SELECTOR_QUERY = gql`
name
solidHandles {
handleID
...GraphExplorerSolidHandleFragment
solid {
name
definition {
Expand Down Expand Up @@ -493,6 +498,7 @@ const BACKFILL_SELECTOR_QUERY = gql`
runQueuingSupported
}
}
${GRAPH_EXPLORER_SOLID_HANDLE_FRAGMENT}
`;

function messageForLaunchBackfillError(data: LaunchPartitionBackfill | null | undefined) {
Expand Down
33 changes: 11 additions & 22 deletions js_modules/dagit/packages/core/src/partitions/PartitionViewNew.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ import {PartitionStepStatus} from './PartitionStepStatus';
import {
PartitionsStatusQuery_partitionSetOrError_PartitionSet_partitionStatusesOrError_PartitionStatuses_results,
PartitionsStatusQuery_partitionSetOrError_PartitionSet_partitionsOrError_Partitions_results,
PartitionsStatusQuery_partitionSetOrError_PartitionSet_partitionRuns,
PartitionsStatusQuery_partitionSetOrError_PartitionSet,
PartitionsStatusQuery,
PartitionsStatusQueryVariables,
Expand Down Expand Up @@ -143,17 +142,15 @@ const PartitionViewContent: React.FC<{
});
});
const statusData: {[name: string]: RunStatus | null} = {};
partitionSet.partitionRuns.forEach(
(partition: PartitionsStatusQuery_partitionSetOrError_PartitionSet_partitionRuns) => {
statusData[partition.partitionName] = partition.run ? partition.run.status : null;
if (selectedPartitions.includes(partition.partitionName)) {
runDurationData[partition.partitionName] =
partition.run && partition.run.startTime && partition.run.endTime
? partition.run.endTime - partition.run.startTime
: undefined;
}
},
);
(partitionSet.partitionStatusesOrError.__typename === 'PartitionStatuses'
? partitionSet.partitionStatusesOrError.results
: []
).forEach((p) => {
statusData[p.partitionName] = p.runStatus;
if (selectedPartitions.includes(p.partitionName)) {
runDurationData[p.partitionName] = p.runDuration || undefined;
}
});

const onSubmit = React.useCallback(() => setBlockDialog(true), []);

Expand Down Expand Up @@ -409,22 +406,14 @@ const PARTITIONS_STATUS_QUERY = gql`
}
}
}
partitionRuns {
id
partitionName
run {
id
status
startTime
endTime
}
}
partitionStatusesOrError {
__typename
... on PartitionStatuses {
results {
id
partitionName
runStatus
runDuration
}
}
...PythonErrorFragment
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit d32fcff

Please sign in to comment.