move software-defined assets toy to asset collection (#6643)

dagster-io · Feb 23, 2022 · d7d1351 · d7d1351
1 parent 091702a
commit d7d1351
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/python_modules/dagster-test/dagster_test/graph_job_op_toys/repo.py b/python_modules/dagster-test/dagster_test/graph_job_op_toys/repo.py
@@ -23,7 +23,7 @@
 from dagster_test.graph_job_op_toys.notebooks import hello_world_notebook_pipeline
 from dagster_test.graph_job_op_toys.retries import retry_job
 from dagster_test.graph_job_op_toys.sleepy import sleepy_job
-from dagster_test.graph_job_op_toys.software_defined_assets import software_defined_assets_job
+from dagster_test.graph_job_op_toys.software_defined_assets import software_defined_assets
 from dagster_test.graph_job_op_toys.unreliable import unreliable_job
 
 from .schedules import get_toys_schedules
@@ -70,9 +70,9 @@ def toys_repository():
             asset_lineage_partition_set,
             model_job,
             hello_world_notebook_pipeline,
-            software_defined_assets_job,
             big_honkin_assets_job,
             long_asset_keys_job,
+            software_defined_assets,
         ]
         + get_toys_schedules()
         + get_toys_sensors()

diff --git a/python_modules/dagster-test/dagster_test/graph_job_op_toys/software_defined_assets.py b/python_modules/dagster-test/dagster_test/graph_job_op_toys/software_defined_assets.py
@@ -1,7 +1,7 @@
 # pylint: disable=redefined-outer-name
 import time
 
-from dagster import AssetKey, IOManager, IOManagerDefinition, SourceAsset, asset, build_assets_job
+from dagster import AssetGroup, AssetKey, IOManager, IOManagerDefinition, SourceAsset, asset
 
 sfo_q2_weather_sample = SourceAsset(key=AssetKey("sfo_q2_weather_sample"))
 
@@ -36,8 +36,7 @@ def hottest_dates(daily_temperature_highs: DataFrame) -> DataFrame:
     return DataFrame()
 
 
-software_defined_assets_job = build_assets_job(
-    "weather",
+software_defined_assets = AssetGroup(
     assets=[daily_temperature_highs, hottest_dates],
     source_assets=[sfo_q2_weather_sample],
     resource_defs={"io_manager": IOManagerDefinition.hardcoded_io_manager(DummyIOManager())},

diff --git a/python_modules/dagster-test/dagster_test_tests/test_graph_job_op_toys.py b/python_modules/dagster-test/dagster_test_tests/test_graph_job_op_toys.py
@@ -26,7 +26,7 @@
 from dagster_test.graph_job_op_toys.retries import retry
 from dagster_test.graph_job_op_toys.schedules import longitudinal_schedule
 from dagster_test.graph_job_op_toys.sleepy import sleepy
-from dagster_test.graph_job_op_toys.software_defined_assets import software_defined_assets_job
+from dagster_test.graph_job_op_toys.software_defined_assets import software_defined_assets
 from dagster_tests.execution_tests.engine_tests.test_step_delegating_executor import (
     test_step_delegating_executor,
 )
@@ -297,4 +297,4 @@ def test_retry_job(executor_def):
 
 
 def test_software_defined_assets_job():
-    assert software_defined_assets_job.execute_in_process().success
+    assert software_defined_assets.build_job("all_assets").execute_in_process().success