Skip to content

Commit

Permalink
Support overriding run config for partitions with execute_in_process (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
sryza committed Oct 31, 2022
1 parent 997fdbb commit da7555c
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -383,18 +383,16 @@ def execute_in_process(
check.failed(
f"Provided partition key `{partition_key}` for job `{self._name}` without a partitioned config"
)
check.invariant(
not run_config,
"Cannot provide both run_config and partition_key arguments to `execute_in_process`",
)
partition_set = self.get_partition_set_def()
if not partition_set:
check.failed(
f"Provided partition key `{partition_key}` for job `{self._name}` without a partitioned config"
)

partition = partition_set.get_partition(partition_key)
run_config = partition_set.run_config_for_partition(partition)
run_config = (
run_config if run_config else partition_set.run_config_for_partition(partition)
)
tags = partition_set.tags_for_partition(partition)

return core_execute_in_process(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,22 @@ def the_asset(context):
assert result.success


def test_materialize_to_memory_partition_key_and_run_config():
@asset(config_schema={"value": str})
def configurable(context):
assert context.op_config["value"] == "a"

@asset(partitions_def=DailyPartitionsDefinition(start_date="2022-09-11"))
def partitioned(context):
assert context.partition_key == "2022-09-11"

assert materialize_to_memory(
[partitioned, configurable],
partition_key="2022-09-11",
run_config={"ops": {"configurable": {"config": {"value": "a"}}}},
).success


def test_materialize_to_memory_provided_io_manager_instance():
@io_manager
def the_manager():
Expand Down

0 comments on commit da7555c

Please sign in to comment.