Switch sensor/schedule view to show tick list instead of run list (#6861

) * tick list * get last cursor value off of state, not tick * allow for copying of cursor values * black; isort * address lint issues * remove unused queries * query persist filters, add seconds to timestamp, hide skipped by default * simplify tick timeline * failure tick tag link * combine ticks / run history * set cursor dialog * fix lint checks * rebase, error handling, show recent ticks always * resolve lint errors * fix error
dagster-io · Mar 12, 2022 · daa1188 · daa1188
1 parent ce4b5ae
commit daa1188
Show file tree

Hide file tree

Showing 28 changed files with 665 additions and 632 deletions.
diff --git a/js_modules/dagit/packages/core/src/instance/types/InstanceSchedulesQuery.ts b/js_modules/dagit/packages/core/src/instance/types/InstanceSchedulesQuery.ts
diff --git a/js_modules/dagit/packages/core/src/instance/types/InstanceSensorsQuery.ts b/js_modules/dagit/packages/core/src/instance/types/InstanceSensorsQuery.ts
diff --git a/js_modules/dagit/packages/core/src/instigation/HistoricalTickTimeline.tsx b/js_modules/dagit/packages/core/src/instigation/HistoricalTickTimeline.tsx
diff --git a/js_modules/dagit/packages/core/src/instigation/InstigationTick.tsx b/js_modules/dagit/packages/core/src/instigation/InstigationTick.tsx
@@ -75,23 +75,26 @@ export const TickTag: React.FC<{
         return <TagWIP intent="danger">Failure</TagWIP>;
       } else {
         const error = tick.error;
+        const showError = () =>
+          showCustomAlert({
+            title: instigationType
+              ? instigationType === InstigationType.SCHEDULE
+                ? 'Schedule Response'
+                : 'Sensor Response'
+              : 'Python Error',
+            body: <PythonErrorInfo error={error} />,
+          });
         return (
-          <LinkButton
-            onClick={() =>
-              showCustomAlert({
-                title: instigationType
-                  ? instigationType === InstigationType.SCHEDULE
-                    ? 'Schedule Response'
-                    : 'Sensor Response'
-                  : 'Python Error',
-                body: <PythonErrorInfo error={error} />,
-              })
-            }
-          >
-            <TagWIP minimal={true} intent="danger">
-              Failure
-            </TagWIP>
-          </LinkButton>
+          <>
+            <LinkButton onClick={showError}>
+              <TagWIP minimal={true} intent="danger">
+                Failure
+              </TagWIP>
+            </LinkButton>
+            <ButtonLink onClick={showError} style={{marginLeft: 8, fontSize: 14}}>
+              View error
+            </ButtonLink>
+          </>
         );
       }
     default: