Skip to content

Commit

Permalink
Remove redundant k8s launcher event (#7250)
Browse files Browse the repository at this point in the history
We added the two logs here for debugging when the k8s api call fails. We might want to use that again, but we can at least remove the duplicate spew of metadata.

![Screen Shot 2022-03-31 at 11 03 09 AM](https://user-images.githubusercontent.com/22018973/161087203-a506d43e-245b-4af6-99c4-5fe74f170c8d.png)
  • Loading branch information
johannkm committed Mar 31, 2022
1 parent b9284ce commit dd6f57e
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions python_modules/libraries/dagster-k8s/dagster_k8s/launcher.py
Original file line number Diff line number Diff line change
Expand Up @@ -278,13 +278,6 @@ def _launch_k8s_job_with_args(self, job_name, args, run, pipeline_origin):
self._instance.report_engine_event(
"Kubernetes run worker job created",
run,
EngineEventData(
[
MetadataEntry("Kubernetes Job name", value=job_name),
MetadataEntry("Kubernetes Namespace", value=self.job_namespace),
MetadataEntry("Run ID", value=run.run_id),
]
),
cls=self.__class__,
)

Expand Down

0 comments on commit dd6f57e

Please sign in to comment.