Skip to content

Commit

Permalink
Added the default group name for assets defined using Out(...) (#8259)
Browse files Browse the repository at this point in the history
This is a follow up on #8226 (Default asset group name) to set the default group name for assets defined using `Out(asset_key=..)`. Such assets did not get the default group name in the original PR.
  • Loading branch information
shalabhc committed Jun 8, 2022
1 parent 08b4fcf commit df10793
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
SensorDefinition,
)
from dagster.core.definitions.time_window_partitions import TimeWindowPartitionsDefinition
from dagster.core.definitions.utils import DEFAULT_GROUP_NAME
from dagster.core.errors import DagsterInvalidDefinitionError
from dagster.core.snap import PipelineSnapshot
from dagster.serdes import DefaultNamedTupleSerializer, whitelist_for_serdes
Expand Down Expand Up @@ -914,7 +915,10 @@ def external_asset_graph_from_defs(
output_name=output_def.name,
output_description=output_def.description,
metadata_entries=output_def.metadata_entries,
group_name=group_names.get(asset_key),
# assets defined by Out(asset_key="k") do not have any group
# name specified we default to DEFAULT_GROUP_NAME here to ensure
# such assets are part of the default group
group_name=group_names.get(asset_key, DEFAULT_GROUP_NAME),
)
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ def assets_job():
depended_by=[ExternalAssetDependedBy(AssetKey("b"))],
job_names=["assets_job"],
output_name="a",
group_name=None,
group_name=DEFAULT_GROUP_NAME,
),
ExternalAssetNode(
asset_key=AssetKey("b"),
Expand All @@ -500,7 +500,7 @@ def assets_job():
depended_by=[],
job_names=["assets_job"],
output_name="b",
group_name=None,
group_name=DEFAULT_GROUP_NAME,
),
]

Expand Down

0 comments on commit df10793

Please sign in to comment.