Skip to content

Commit

Permalink
[dagit] Disallow use of gql from graphql.macro (#7042)
Browse files Browse the repository at this point in the history
  • Loading branch information
bengotow committed Mar 16, 2022
1 parent 69f5e3b commit e282d44
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 2 deletions.
5 changes: 5 additions & 0 deletions js_modules/dagit/packages/core/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,11 @@ module.exports = {
name: 'graphql-tag',
message: 'Please import from `@apollo/client`.',
},
{
name: 'graphql.macro',
importNames: ['gql'],
message: 'Please import from `@apollo/client`.',
},
{
name: 'styled-components',
message: 'Please import from `styled-components/macro`.',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {gql} from '@apollo/client';
import {Box, ColorsWIP, Group, IconWIP, Mono, NonIdealState, Table} from '@dagster-io/ui';
import {gql} from 'graphql.macro';
import qs from 'qs';
import * as React from 'react';
import {Link} from 'react-router-dom';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {gql} from '@apollo/client';
import {Box, ColorsWIP, TagWIP, Tooltip} from '@dagster-io/ui';
import {Spacing} from '@dagster-io/ui/src/components/types';
import {gql} from 'graphql.macro';
import * as React from 'react';
import styled from 'styled-components/macro';

Expand Down
5 changes: 5 additions & 0 deletions js_modules/dagit/packages/ui/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,11 @@ module.exports = {
name: 'graphql-tag',
message: 'Please import from `@apollo/client`.',
},
{
name: 'graphql.macro',
importNames: ['gql'],
message: 'Please import from `@apollo/client`.',
},
{
name: 'styled-components',
message: 'Please import from `styled-components/macro`.',
Expand Down

1 comment on commit e282d44

@vercel
Copy link

@vercel vercel bot commented on e282d44 Mar 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

dagit-storybook – ./js_modules/dagit/packages/ui

dagit-storybook.vercel.app
dagit-storybook-elementl.vercel.app
dagit-storybook-git-master-elementl.vercel.app

Please sign in to comment.