refactor: rename is_failure to is_failure_or_canceled (#7200)

dagster-io · Mar 25, 2022 · e642465 · e642465
1 parent 7c69b8e
commit e642465
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_retry_execution.py b/python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_retry_execution.py
@@ -548,7 +548,7 @@ def test_retry_requires_intermediates_async_only(self, graphql_context):
         _do_retry_intermediates_test(graphql_context, run_id, reexecution_run_id)
         reexecution_run = graphql_context.instance.get_run_by_id(reexecution_run_id)
 
-        assert reexecution_run.is_failure
+        assert reexecution_run.is_failure_or_canceled
 
     def test_retry_early_terminate(self, graphql_context):
         instance = graphql_context.instance

diff --git a/python_modules/dagster/dagster/core/storage/pipeline_run.py b/python_modules/dagster/dagster/core/storage/pipeline_run.py
@@ -412,6 +412,10 @@ def is_success(self):
 
     @property
     def is_failure(self):
+        return self.status == PipelineRunStatus.FAILURE
+
+    @property
+    def is_failure_or_canceled(self):
         return self.status == PipelineRunStatus.FAILURE or self.status == PipelineRunStatus.CANCELED
 
     @property

diff --git a/python_modules/dagster/dagster_tests/core_tests/test_pipeline_execution.py b/python_modules/dagster/dagster_tests/core_tests/test_pipeline_execution.py
@@ -702,7 +702,7 @@ def failing_init_pipeline():
     event = result.event_list[-1]
     assert event.event_type_value == "PIPELINE_FAILURE"
     assert event.pipeline_failure_data
-    assert mem_instance.get_run_by_id(result.run_id).is_failure
+    assert mem_instance.get_run_by_id(result.run_id).is_failure_or_canceled
 
     with instance_for_test() as fs_instance:
         result = execute_pipeline(
@@ -715,7 +715,7 @@ def failing_init_pipeline():
         event = result.event_list[-1]
         assert event.event_type_value == "PIPELINE_FAILURE"
         assert event.pipeline_failure_data
-        assert fs_instance.get_run_by_id(result.run_id).is_failure
+        assert fs_instance.get_run_by_id(result.run_id).is_failure_or_canceled
 
 
 def test_reexecution_fs_storage():