[postgres] dont dispose engine in watch thread (#7241)

dagster-io · Mar 30, 2022 · e66faf9 · e66faf9
1 parent ff9596f
commit e66faf9
Showing 1 changed file with 9 additions and 12 deletions.
diff --git a/python_modules/libraries/dagster-postgres/dagster_postgres/event_log/event_log.py b/python_modules/libraries/dagster-postgres/dagster_postgres/event_log/event_log.py
@@ -313,18 +313,15 @@ def watcher_thread(
             with dict_lock:
                 handlers = handlers_dict.get(run_id, [])
 
-            try:
-                with engine.connect() as conn:
-                    cursor_res = conn.execute(
-                        db.select([SqlEventLogStorageTable.c.event]).where(
-                            SqlEventLogStorageTable.c.id == index
-                        ),
-                    )
-                    dagster_event: EventLogEntry = deserialize_json_to_dagster_namedtuple(
-                        cursor_res.scalar()
-                    )
-            finally:
-                engine.dispose()
+            with engine.connect() as conn:
+                cursor_res = conn.execute(
+                    db.select([SqlEventLogStorageTable.c.event]).where(
+                        SqlEventLogStorageTable.c.id == index
+                    ),
+                )
+                dagster_event: EventLogEntry = deserialize_json_to_dagster_namedtuple(
+                    cursor_res.scalar()
+                )
 
             for callback_with_cursor in handlers:
                 if callback_with_cursor.start_cursor < index: