remove jinja / nbconvert pin (#7819)

* remove jinja pin * remove nbconvert pin * dagstermill tests * remove template reference * papermill remove steps * ge_example * add pin for great expectations * unpin * pin example * add back tests for papermill 1
dagster-io · May 10, 2022 · e6c5bb0 · e6c5bb0
1 parent ccb2fd1
commit e6c5bb0
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 10 deletions.
diff --git a/examples/ge_example/setup.py b/examples/ge_example/setup.py
@@ -10,7 +10,7 @@
         "dagster",
         "dagit",
         "dagster-ge",
-        "great_expectations",
+        "great_expectations>=0.14.12",  # pinned because pip is using the cached wheel for 0.13.14
     ],
     author="Elementl",
     license="Apache-2.0",

diff --git a/python_modules/dagit/dagit/webserver.py b/python_modules/dagit/dagit/webserver.py
@@ -139,7 +139,6 @@ async def download_notebook(self, request: Request):
         # parse content to HTML
         notebook = nbformat.reads(notebook_content, as_version=4)
         html_exporter = HTMLExporter()
-        html_exporter.template_file = "basic"
         (body, resources) = html_exporter.from_notebook_node(notebook)
         return HTMLResponse("<style>" + resources["inlining"]["css"][0] + "</style>" + body)
 

diff --git a/python_modules/dagit/setup.py b/python_modules/dagit/setup.py
@@ -47,14 +47,11 @@ def get_version():
             "click>=7.0,<9.0",
             f"dagster{pin}",
             f"dagster-graphql{pin}",
-            # 5.2+ stops pulling in `ipython_genutils`, on which the old version of `nbconvert` we use
-            # implicitly depends. Can remove nbformat dependency entirely when/if cap on nbconvert is lifted.
-            "nbformat<=5.1.3",
             "requests",
             # watchdog
             "watchdog>=0.8.3",
             # notebooks support
-            "nbconvert>=5.4.0,<6.0.0",
+            "nbconvert",
             "starlette",
             "uvicorn[standard]",
         ],

diff --git a/python_modules/dagster/setup.py b/python_modules/dagster/setup.py
@@ -60,8 +60,7 @@ def get_version() -> str:
             "click>=5.0",
             "coloredlogs>=6.1, <=14.0",
             "contextvars; python_version < '3.7'",
-            # https://github.com/dagster-io/dagster/issues/4167
-            "Jinja2<3.0",
+            "Jinja2",
             "markupsafe<=2.0.1",
             "PyYAML>=5.1",
             # core (not explicitly expressed atm)

diff --git a/python_modules/libraries/dagster-dbt/setup.py b/python_modules/libraries/dagster-dbt/setup.py
@@ -42,8 +42,7 @@ def get_version() -> str:
         ],
         extras_require={
             "test": [
-                # https://github.com/dagster-io/dagster/issues/4167
-                "Jinja2<3.0",
+                "Jinja2",
                 "dbt-core",
                 "dbt-rpc",
                 "dbt-postgres",

diff --git a/python_modules/libraries/dagstermill/tox.ini b/python_modules/libraries/dagstermill/tox.ini
@@ -12,6 +12,8 @@ deps =
   papermill1: papermill<2.0.0
   papermill1: jupyter-client<6.1.13
   papermill1: nbconvert<6.0.0
+  papermill1: nbformat<=5.1.3
+  papermill1: Jinja2<3.0
   -e ../../dagster[test]
   -e ../dagster-pandas
 allowlist_externals =