fix pylint for modern data stack example (#6975)

dagster-io · Mar 7, 2022 · e703ac6 · e703ac6
1 parent 2649808
commit e703ac6
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/examples/modern_data_stack_assets/modern_data_stack_assets/assets.py b/examples/modern_data_stack_assets/modern_data_stack_assets/assets.py
@@ -1,3 +1,4 @@
+# pylint: disable=redefined-outer-name
 from typing import Any, Tuple
 
 import numpy as np
@@ -6,9 +7,9 @@
 from dagster_dbt import dbt_cli_resource, load_assets_from_dbt_project
 from scipy import optimize
 
-from dagster import AssetGroup, Output, asset
+from dagster import AssetGroup, asset
 
-from .constants import *
+from .constants import *  # pylint: disable=wildcard-import,unused-wildcard-import
 from .pandas_io_manager import pandas_io_manager
 
 airbyte_assets = build_airbyte_assets(

diff --git a/examples/modern_data_stack_assets/modern_data_stack_assets/forecasting.py b/examples/modern_data_stack_assets/modern_data_stack_assets/forecasting.py
@@ -15,6 +15,7 @@ def order_forecast_model(daily_order_summary: pd.DataFrame) -> Tuple[Any, Any]:
     )[0]
 
 
+# pylint: disable=redefined-outer-name
 def predicted_orders(
     daily_order_summary: pd.DataFrame, order_forecast_model: Tuple[float, float]
 ) -> pd.DataFrame:

diff --git a/examples/modern_data_stack_assets/modern_data_stack_assets/setup_airbyte.py b/examples/modern_data_stack_assets/modern_data_stack_assets/setup_airbyte.py
@@ -1,3 +1,4 @@
+# pylint: disable=print-call
 """
 A basic script that will create tables in the source postgres database, then automatically
 create an Airbyte Connection between the source database and destination database.

diff --git a/examples/modern_data_stack_assets/tox.ini b/examples/modern_data_stack_assets/tox.ini
@@ -22,16 +22,13 @@ commands =
   pytest -vv
 
 [testenv:pylint]
-whitelist_externals =
-  echo
-  pylint
 commands =
-  echo -e "--- \033[0;32m:lint-roller: Running pylint\033[0m"
+  pylint -j 1 --rcfile=../../.pylintrc modern_data_stack_assets modern_data_stack_assets_tests
 
 [testenv:mypy]
 whitelist_externals =
   echo
   mypy
 commands =
   echo -e "--- \033[0;32m:mypy: Running mypy\033[0m"
-  mypy -p modern_data_stack_assets --namespace-packages --ignore-missing-imports
+  mypy -p modern_data_stack_assets --namespace-packages --ignore-missing-imports