-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[@dagster-io/ui] Separate tsconfig for build (#7584)
## Summary Create a separate `tsconfig.build.json` to produce built output, specifically excluding `stories.*` and `test.*` files, since we don't actually want to ship type declarations for these. This should resolve an issue where an `internal` project that imports from `@dagster-io/ui` is ending up with incorrect types that are being affected by the creation of `stories` typedefs. I'll publish this as 1.0.4, so I updated the changelog accordingly. ## Test Plan `yarn build`, verify that `stories.d.ts` and `test.d.ts` files are no longer included in the build output. `yarn ts`, verify that regular non-emitting TS check still works as exepcted. In internal project, link to this package locally. Verify that the TS error goes away with the newly generated types.
- Loading branch information
Showing
4 changed files
with
70 additions
and
43 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
{ | ||
"extends": "./tsconfig", | ||
"compilerOptions": { | ||
"outDir": "lib", | ||
"noEmit": false, | ||
"declaration": true, | ||
"emitDeclarationOnly": true | ||
}, | ||
"exclude": [ | ||
"node_modules", | ||
"lib", | ||
"**/*.stories.*", | ||
"**/*.test.*" | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,44 +1,44 @@ | ||
{ | ||
"compilerOptions": { | ||
"module": "esnext", | ||
"target": "es5", | ||
"lib": [ | ||
"es6", | ||
"dom", | ||
"esnext.asynciterable" | ||
], | ||
"outDir": "lib", | ||
"rootDir": "src", | ||
"noEmit": true, | ||
"sourceMap": true, | ||
"allowJs": true, | ||
"jsx": "react", | ||
"moduleResolution": "node", | ||
"forceConsistentCasingInFileNames": true, | ||
"noImplicitReturns": true, | ||
"noImplicitThis": true, | ||
"noImplicitAny": true, | ||
"strictNullChecks": true, | ||
"suppressImplicitAnyIndexErrors": true, | ||
"noUncheckedIndexedAccess": true, | ||
"allowSyntheticDefaultImports": true, | ||
"types": [ | ||
"jest", | ||
"node" | ||
], | ||
"skipLibCheck": true, | ||
"esModuleInterop": true, | ||
"strict": true, | ||
"resolveJsonModule": true, | ||
"isolatedModules": true, | ||
"noFallthroughCasesInSwitch": true | ||
}, | ||
"exclude": [ | ||
"node_modules", | ||
"compilerOptions": { | ||
"module": "esnext", | ||
"target": "es5", | ||
"lib": [ | ||
"es6", | ||
"dom", | ||
"esnext.asynciterable" | ||
], | ||
"include": [ | ||
"src", | ||
"types" | ||
] | ||
} | ||
"rootDir": "src", | ||
"noEmit": true, | ||
"sourceMap": true, | ||
"allowJs": true, | ||
"jsx": "react", | ||
"moduleResolution": "node", | ||
"forceConsistentCasingInFileNames": true, | ||
"noImplicitReturns": true, | ||
"noImplicitThis": true, | ||
"noImplicitAny": true, | ||
"strictNullChecks": true, | ||
"suppressImplicitAnyIndexErrors": true, | ||
"noUncheckedIndexedAccess": true, | ||
"allowSyntheticDefaultImports": true, | ||
"types": [ | ||
"jest", | ||
"node" | ||
], | ||
"skipLibCheck": true, | ||
"esModuleInterop": true, | ||
"strict": true, | ||
"resolveJsonModule": true, | ||
"isolatedModules": true, | ||
"noFallthroughCasesInSwitch": true | ||
}, | ||
"exclude": [ | ||
"node_modules", | ||
"lib", | ||
], | ||
"include": [ | ||
"src", | ||
"types" | ||
] | ||
} | ||
|
ee4cb0e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs:
dagit-storybook – ./js_modules/dagit/packages/ui
dagit-storybook-elementl.vercel.app
dagit-storybook-git-master-elementl.vercel.app
dagit-storybook.vercel.app