[dagit] Ignore source assets for “Materialize All” button (#7196)

dagster-io · Mar 31, 2022 · f064389 · f064389
1 parent 8f271ef
commit f064389
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 10 deletions.
diff --git a/js_modules/dagit/packages/core/src/assets/AssetNodeDefinition.tsx b/js_modules/dagit/packages/core/src/assets/AssetNodeDefinition.tsx
@@ -9,7 +9,7 @@ import {Description} from '../pipelines/Description';
 import {instanceAssetsExplorerPathToURL} from '../pipelines/PipelinePathUtils';
 import {PipelineReference} from '../pipelines/PipelineReference';
 import {ASSET_NODE_FRAGMENT, ASSET_NODE_LIVE_FRAGMENT} from '../workspace/asset-graph/AssetNode';
-import {LiveData, __ASSET_GROUP} from '../workspace/asset-graph/Utils';
+import {isSourceAsset, LiveData, __ASSET_GROUP} from '../workspace/asset-graph/Utils';
 import {buildRepoAddress} from '../workspace/buildRepoAddress';
 import {RepoAddress} from '../workspace/types';
 
@@ -135,7 +135,7 @@ const JobGraphLink: React.FC<{
   assetNode: AssetNodeDefinitionFragment;
   direction: 'upstream' | 'downstream';
 }> = ({direction, assetNode}) => {
-  if (assetNode.jobNames.length === 0 || !assetNode.opName) {
+  if (isSourceAsset(assetNode)) {
     return null;
   }
   const populated =
@@ -185,7 +185,7 @@ const DefinitionLocation: React.FC<{
       </Box>
     )}
 
-    {assetNode.jobNames.length === 0 && !assetNode.opName && (
+    {isSourceAsset(assetNode) && (
       <Caption style={{lineHeight: '16px', marginTop: 2}}>Source Asset</Caption>
     )}
   </Box>

diff --git a/js_modules/dagit/packages/core/src/workspace/asset-graph/AssetGraphExplorer.tsx b/js_modules/dagit/packages/core/src/workspace/asset-graph/AssetGraphExplorer.tsx
@@ -50,6 +50,7 @@ import {
   layoutGraph,
   LiveData,
   Node,
+  isSourceAsset,
 } from './Utils';
 import {AssetGraphLiveQuery, AssetGraphLiveQueryVariables} from './types/AssetGraphLiveQuery';
 import {
@@ -222,7 +223,7 @@ const AssetGraphExplorerWithData: React.FC<
   const lastSelectedNode = selectedGraphNodes[selectedGraphNodes.length - 1];
   const launchGraphNodes = selectedGraphNodes.length
     ? selectedGraphNodes
-    : Object.values(assetGraphData.nodes);
+    : Object.values(assetGraphData.nodes).filter((a) => !isSourceAsset(a.definition));
 
   const onSelectNode = React.useCallback(
     async (e: React.MouseEvent<any>, assetKey: {path: string[]}, node: Node | null) => {

diff --git a/js_modules/dagit/packages/core/src/workspace/asset-graph/LaunchAssetExecutionButton.tsx b/js_modules/dagit/packages/core/src/workspace/asset-graph/LaunchAssetExecutionButton.tsx
@@ -6,6 +6,7 @@ import {LaunchRootExecutionButton} from '../../launchpad/LaunchRootExecutionButt
 import {buildRepoAddress} from '../buildRepoAddress';
 
 import {LaunchAssetChoosePartitionsDialog} from './LaunchAssetChoosePartitionsDialog';
+import {isSourceAsset} from './Utils';
 
 type AssetMinimal = {
   assetKey: {path: string[]};
@@ -28,7 +29,7 @@ export const LaunchAssetExecutionButton: React.FC<{
   );
 
   let disabledReason = '';
-  if (!assets.every((a) => a.opName)) {
+  if (assets.some(isSourceAsset)) {
     disabledReason = 'One or more source assets are selected and cannot be materialized.';
   }
   if (
@@ -38,19 +39,22 @@ export const LaunchAssetExecutionButton: React.FC<{
         a.repository.location.name === repoAddress.location,
     )
   ) {
-    disabledReason = 'Assets must be in the same repository to be materialized together.';
+    disabledReason =
+      disabledReason || 'Assets must be in the same repository to be materialized together.';
   }
 
   const everyAssetHasJob = (jobName: string) => assets.every((a) => a.jobNames.includes(jobName));
   const jobsInCommon = assets[0] ? assets[0].jobNames.filter(everyAssetHasJob) : [];
   const jobName = jobsInCommon.find((name) => name === preferredJobName) || jobsInCommon[0];
   if (!jobName) {
-    disabledReason = 'Assets must be in the same job to be materialized together.';
+    disabledReason =
+      disabledReason || 'Assets must be in the same job to be materialized together.';
   }
 
   const partitionDefinition = assets[0]?.partitionDefinition;
   if (assets.some((a) => a.partitionDefinition !== partitionDefinition)) {
-    disabledReason = 'Assets must share a partition definition to be materialized together.';
+    disabledReason =
+      disabledReason || 'Assets must share a partition definition to be materialized together.';
   }
 
   title = title || 'Refresh';

diff --git a/js_modules/dagit/packages/core/src/workspace/asset-graph/Utils.tsx b/js_modules/dagit/packages/core/src/workspace/asset-graph/Utils.tsx
@@ -60,6 +60,10 @@ export type IEdge = {
   dashed: boolean;
 };
 
+export const isSourceAsset = (node: {jobNames: string[]; opName: string | null}) => {
+  return node.jobNames.length === 0 && !node.opName;
+};
+
 export const buildGraphData = (assetNodes: AssetNode[]) => {
   const data: GraphData = {
     nodes: {},
@@ -295,7 +299,6 @@ export const buildLiveData = (
 
     const lastMaterialization = liveNode.assetMaterializations[0] || null;
     const lastStepStart = lastMaterialization?.stepStats?.startTime || 0;
-    const isForeignNode = !liveNode.opName;
     const isPartitioned = graphNode.definition.partitionDefinition;
     const repo = repos.find(
       (r) =>
@@ -323,7 +326,7 @@ export const buildLiveData = (
       unstartedRunIds: runs?.unstartedRuns.map((r) => r.id) || [],
       runsSinceMaterialization,
       runWhichFailedToMaterialize,
-      computeStatus: isForeignNode
+      computeStatus: isSourceAsset(graphNode.definition)
         ? 'good' // foreign nodes are always considered up-to-date
         : isPartitioned
         ? // partitioned nodes are not supported, need to compare materializations