Skip to content

Commit

Permalink
instance var
Browse files Browse the repository at this point in the history
  • Loading branch information
jamiedemaria committed May 23, 2024
1 parent f7d4185 commit f0b41d9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 3 additions & 0 deletions python_modules/dagster/dagster/_core/instance/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -3246,3 +3246,6 @@ def get_asset_check_support(self) -> "AssetCheckInstanceSupport":
if self.event_log_storage.supports_asset_checks
else AssetCheckInstanceSupport.NEEDS_MIGRATION
)

def backfill_log_storage_enabled(self) -> bool:
return False
3 changes: 1 addition & 2 deletions python_modules/dagster/dagster/_daemon/backfill.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import logging
import os
import sys
from contextlib import contextmanager
from typing import Iterable, Mapping, Optional, Sequence, cast
Expand All @@ -19,7 +18,7 @@
def _get_instigation_logger_if_env_var_set(
instance, backfill_id: str, default_logger: logging.Logger
):
if os.getenv("STORE_BACKFILL_LOGS", None):
if instance.backfill_log_storage_enabled():
evaluation_time = pendulum.now("UTC")
log_key = ["backfill", backfill_id, evaluation_time.strftime("%Y%m%d_%H%M%S")]
with InstigationLogger(
Expand Down

0 comments on commit f0b41d9

Please sign in to comment.