-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add partial tag autocomplete for run filter input (#12410)
### Summary & Motivation We disabled tag autocomplete because we were fetching wayyyy too much data for this feature. But we were also fetching tags in a really dumb way, fetching all unique key/value pairs in all run history, and relying on the typeahead to filter appropriately. This PR breaks up tag searches into two phases, first fetching the distinct tag keys, then fixing the tag key and lazily searching for the unique values given a fixed tag key. These instance storage methods were added in #12348 and the graphql endpoints are in #12409. The cardinality of the tag key space is assumed to be low (<1000). The cardinality of the tag value space can be pretty high, especially for some keys like `dagster/partition`, but we can add additional logic down the road for doing prefix searches in the lazy tag search, along with a hard limit. Tracked in #12104 ### How I Tested These Changes https://user-images.githubusercontent.com/1040172/219518626-cad3be26-f4aa-4d9f-876d-a2f23f264409.mov
- Loading branch information
1 parent
2214ad6
commit f131a97
Showing
4 changed files
with
126 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
js_modules/dagit/packages/core/src/runs/types/RunsFilterInput.types.ts
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
18 changes: 18 additions & 0 deletions
18
js_modules/dagit/packages/core/src/runs/types/RunsSearchSpaceQuery.ts
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters