display non-sda assets in asset catalog (#6779)

dagster-io · Feb 24, 2022 · f470ea9 · f470ea9
1 parent e53dec4
commit f470ea9
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 9 deletions.
diff --git a/js_modules/dagit/packages/core/src/assets/AssetTable.tsx b/js_modules/dagit/packages/core/src/assets/AssetTable.tsx
@@ -177,14 +177,18 @@ const AssetEntryRow: React.FC<{
       <td>
         {asset ? (
           <Box flex={{gap: 8, alignItems: 'center'}}>
-            <Link
-              to={instanceAssetsExplorerPathToURL({
-                opsQuery: `++"${tokenForAssetKey({path})}"++`,
-                opNames: [tokenForAssetKey({path})],
-              })}
-            >
-              <ButtonWIP disabled={!asset.definition?.opName}>View in Asset Graph</ButtonWIP>
-            </Link>
+            {asset.definition?.opName ? (
+              <Link
+                to={instanceAssetsExplorerPathToURL({
+                  opsQuery: `++"${tokenForAssetKey({path})}"++`,
+                  opNames: [tokenForAssetKey({path})],
+                })}
+              >
+                <ButtonWIP>View in Asset Graph</ButtonWIP>
+              </Link>
+            ) : (
+              <ButtonWIP disabled={true}>View in Asset Graph</ButtonWIP>
+            )}
             <Popover
               position="bottom-right"
               content={

diff --git a/js_modules/dagit/packages/core/src/assets/AssetsCatalogTable.tsx b/js_modules/dagit/packages/core/src/assets/AssetsCatalogTable.tsx
@@ -230,7 +230,7 @@ const filterAssetsToRepos = (assets: Asset[], visibleRepos: DagsterRepoOption[])
   );
   return assets.filter(
     (a) =>
-      a.definition &&
+      !a.definition ||
       visibleRepoHashes.includes(
         buildRepoPath(a.definition.repository.name, a.definition.repository.location.name),
       ),