-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Don't spew "Aborted!" to the command-line when the Daemon is cleanly …
…interrupted (#11739) Right now whenever you CTRL-C the daemon (or `dagster dev` terminates the daemon) we hit some generic click logic that prints out a scary "Aborted!" message, even though its the expected way to end the process. Instead of bubbling the interrupt up to click, catch it in the CLI command and exit cleanly. uvicorn in dagit has similar logic that causes dagit to exit with return code 0 when an interrupt happens. Test Plan: Run daemon locally, CTRL-C, no more scary "Aborted!" message, same with dagster dev
- Loading branch information
Showing
2 changed files
with
16 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters