Skip to content

Commit

Permalink
[@dagster-io/eslint-config] Fix dependencies (#7354)
Browse files Browse the repository at this point in the history
## Summary

Fix dependency list for `@dagster-io/eslint-config`. These need to be regular dependencies, not dev deps.

## Test Plan

In a test CRA project, install a linked `@dagster-io/eslint-config`. Run lint with this as part of the local config, verify that it works correctly, with no dependency problems.
  • Loading branch information
hellendag committed Apr 8, 2022
1 parent a515c58 commit ff2f632
Show file tree
Hide file tree
Showing 4 changed files with 248 additions and 1,008 deletions.
1 change: 1 addition & 0 deletions js_modules/dagit/packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@
"babel-plugin-macros": "^2.8.0",
"child-process": "^1.0.2",
"eslint": "8.5.0",
"eslint-plugin-graphql": "4.0.0",
"eslint-plugin-storybook": "^0.5.5",
"faker": "5.5.3",
"graphql.macro": "^1.4.2",
Expand Down
4 changes: 4 additions & 0 deletions js_modules/dagit/packages/eslint-config/CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.0.1 (April 7, 2022)

- Fix dependencies

## 1.0.0 (April 6, 2022)

- Initial commit
9 changes: 3 additions & 6 deletions js_modules/dagit/packages/eslint-config/package.json
Original file line number Diff line number Diff line change
@@ -1,24 +1,21 @@
{
"name": "@dagster-io/eslint-config",
"version": "1.0.0",
"version": "1.0.1",
"description": "Shared eslint configuration for @dagster-io",
"license": "Apache-2.0",
"main": "index.js",
"peerDependencies": {
"eslint": "^8.6.0",
"prettier": "2.2.1"
},
"devDependencies": {
"@types/eslint": "^8",
"dependencies": {
"@typescript-eslint/eslint-plugin": "5.8.0",
"@typescript-eslint/parser": "5.8.0",
"eslint-config-prettier": "8.3.0",
"eslint-plugin-graphql": "^4.0.0",
"eslint-plugin-import": "2.26.0",
"eslint-plugin-jsx-a11y": "6.5.1",
"eslint-plugin-prettier": "^4.0.0",
"eslint-plugin-react": "7.27.1",
"eslint-plugin-react-hooks": "4.3.0",
"graphql": "^15.5.0"
"eslint-plugin-react-hooks": "4.3.0"
}
}

0 comments on commit ff2f632

Please sign in to comment.