Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pointing dagit at a repository.yml that references a missing module should warn or error #1359

Closed
mgasner opened this issue May 14, 2019 · 4 comments
Closed

Pointing dagit at a repository.yml that references a missing module should warn or error #1359

mgasner opened this issue May 14, 2019 · 4 comments
Milestone
0.5.0

Comments

@mgasner
Copy link
Contributor

mgasner commented May 14, 2019

e.g. if repository.yml says:

repository:
  module: foobar
  fn: define_repo

dagit silently passes and displays an empty repo
@mgasner mgasner added this to the 0.5.0 milestone May 14, 2019
@natekupp
Copy link
Contributor

Good catch - might be good to add a few more test cases exercising things like this in the tests for the ExecutionTargetHandle object that I just landed

@mgasner
Copy link
Contributor Author

mgasner commented May 15, 2019

cf #1104

@mgasner mgasner added the dagit label May 22, 2019
@mgasner
Copy link
Contributor Author

mgasner commented May 29, 2019

the ExecutionTargetHandle actually raises a ModuleNotFound error as we might expect -- https://dagster.phacility.com/D235 will kill the parent process

@schrockn
Copy link
Member

Confirmed in https://dagster.phacility.com/D241

mgasner added a commit that referenced this issue May 29, 2019
@mgasner
Barf when the child process raises
2883284 
Summary: #1359, #1104

Test Plan: Manual

Reviewers: alangenfeld, schrockn, natekupp

Reviewed By: schrockn

Differential Revision: https://dagster.phacility.com/D235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
3 participants
@mgasner @natekupp @schrockn