Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass parent_run_id tag from dagit to dagster core storage #2296

Closed
yuhan opened this issue Mar 19, 2020 · 0 comments
Closed

Pass parent_run_id tag from dagit to dagster core storage #2296

yuhan opened this issue Mar 19, 2020 · 0 comments
Assignees
@yuhan
Projects
0.8.0 Run Grouping

Comments

@yuhan
Copy link
Contributor

yuhan commented Mar 19, 2020

when we hit the Re-execute button in dagit, make sure that a dagster/parent_run_id tag is set on the run that gets created, and that that tag is available when we query for runs from the front-end
@yuhan yuhan created this issue from a note in 0.8.0 Run Grouping (To Do) Mar 19, 2020
@yuhan yuhan added 0.8.0 and removed 0.8.0 labels Mar 19, 2020
@yuhan yuhan self-assigned this Mar 19, 2020
yuhan added a commit that referenced this issue Mar 23, 2020
@yuhan
#2296 add dagster/parent_run_id tag when re-execution
f29a3f7 
Summary:
Issue: #2296
initial sketch.

Test Plan:
  - BK
  - dagit showed `parent_run_id` on runtable {F105412}
  - `PipelineRun` in `dagster.core.storage` received the `dagster/parent_run_id` tag
```
> /Users/yuhan/dev/dagster/python_modules/dagster/dagster/core/storage/pipeline_run.py(92)__new__()
     91         ipdb.set_trace()
---> 92         return super(PipelineRun, cls).__new__(
     93             cls,

ipdb> tags
{'dagster/parent_run_id': 'b5bbb1cd-154c-4a68-92db-691f8fde3890'}
```

Reviewers: max

Reviewed By: max

Subscribers: alangenfeld

Differential Revision: https://dagster.phacility.com/D2322
@yuhan yuhan moved this from To Do to Done in 0.8.0 Run Grouping Mar 24, 2020
@yuhan yuhan closed this as completed Mar 24, 2020
@yuhan yuhan changed the title Make sure run tag is available and passed through end-to-end Pass parent_run_id tag from dagit to dagster core storage Mar 24, 2020
@yuhan yuhan mentioned this issue Mar 24, 2020
Closed
@yuhan yuhan mentioned this issue Jun 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuhan yuhan

Labels
None yet
Projects
No open projects
0.8.0 Run Grouping
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yuhan